Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.2.0 with nghttp2 now requires nghttp2 1.15.0 #11470

Closed
pghmcfc opened this issue Jul 19, 2023 · 0 comments
Closed

8.2.0 with nghttp2 now requires nghttp2 1.15.0 #11470

pghmcfc opened this issue Jul 19, 2023 · 0 comments
Assignees
@bagder
Labels
build HTTP/2

Comments

@pghmcfc
Copy link
Contributor

pghmcfc commented Jul 19, 2023

I did this

Tried to build curl 8.2.0 with nghttp2 support on Fedora 25 with nghttp2 1.13.0

I expected the following

Successful build, as usual.

curl/libcurl version

8.2.0

operating system

Fedora Linux 25

Build fails like this:

../../lib/http2.c: In function 'on_stream_frame':
../../lib/http2.c:1010:23: error: implicit declaration of function 'nghttp2_session_get_stream_local_window_size' [-Werror=implicit-function-declaration]
       int32_t wsize = nghttp2_session_get_stream_local_window_size(
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

The nghttp2_session_get_stream_local_window_size function was added in nghttp2 version 1.15.0 (https://github.com/nghttp2/nghttp2/releases/tag/v1.15.0). The configure script is checking for nghttp2_session_set_local_window_size, which according to the comment in the configure script, was introduced in version 1.12.0. So it would seem that checking for the "get" function instead of the "set" function would fix this, at the expense of disabling nghttp2 support in Fedora 25.
bagder added a commit that referenced this issue Jul 19, 2023
@bagder
configure: check for nghttp2_session_get_stream_local_window_size
1c000be 
The http2 code uses it now. Introduced in nghttp2 1.15.0 (Sep 2016)

Fixes #11470
Reported-by: Paul Howarth
@bagder bagder mentioned this issue Jul 19, 2023
Closed
@bagder bagder self-assigned this Jul 19, 2023
@bagder bagder closed this as completed in 2900c29 Jul 19, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
configure: check for nghttp2_session_get_stream_local_window_size
58fd5be 
The http2 code uses it now. Introduced in nghttp2 1.15.0 (Sep 2016)

Fixes curl#11470
Reported-by: Paul Howarth
Closes curl#11473
ptitSeb pushed a commit to wasix-org/curl that referenced this issue Sep 25, 2023
@bagder @ptitSeb
configure: check for nghttp2_session_get_stream_local_window_size
6ea01fa 
The http2 code uses it now. Introduced in nghttp2 1.15.0 (Sep 2016)

Fixes curl#11470
Reported-by: Paul Howarth
Closes curl#11473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build HTTP/2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: check for nghttp2_session_get_stream_local_window_size curl/curl
2 participants
@bagder @pghmcfc