osreldate.h doesn't exist on PlayStation

[fffaraz]

I did this

Build fails on PlayStation due to missing osreldate.h

I expected the following

No response

curl/libcurl version

curl 8.4.0

operating system

PlayStation

[jay]

curl/include/curl/curl.h

Lines 68 to 71 in d755a5f

	#if (defined(__FreeBSD__) && (__FreeBSD__ >= 2)) || defined(__MidnightBSD__)
	/* Needed for __FreeBSD_version or __MidnightBSD_version symbol definition */
	#include <osreldate.h>
	#endif

FreeBSD manual says use #include <sys/param.h>.

I'm not sure why we're using osreldate, maybe for legacy reasons. What version of FreeBSD are you using? What happens if you #include <sys/param.h>

[bagder]

The include was brought in 2009, apparently to fix a build with FreeBSD < v8: b89789d

[bagder]

Maybe #12109 ?

[emaste]

osreldate.h should exist on any FreeBSD version, but sys/param.h is also fine for defining __FreeBSD_version.

Here's a rather recent commit I found when looking for details: freebsd/freebsd-src@90eaf4b

[Freaky]

FreeBSD manual also says to use osreldate.h, sysctl(3):

The userland release version is available from <osreldate.h>;
parse this file if you need to get the release version of the
currently installed userland.

It's used a fair bit by the base system, including this example of how to find the FreeBSD version.

[bagder]

Thank you both @emaste and @Freaky. This seems to rather imply that either @fffaraz's setup is bad somehow or Sony has done something "fun" for the PlayStation that requires a special take.

Either way, my take in 12109 seems incorrect.

[fffaraz]

PlayStation sdk does not have osreldate.h but it does have sys/param.h and it defines __FreeBSD_version as
#define __FreeBSD_version 900044 /* Master, propagated to newvers */

[dfandrich]

FWIW, I checked a FreeBSD 6.2 image I have lying around and either sys/param.h or osreldate.h work fine to define __FreeBSD_version.

[Freaky]

osreldate.h is generated during the build, while sys/param.h is a static source of truth in the source tree, used by sys/conf/newvers.sh. Perhaps some setup step for the SDK's been missed?

[bagder]

Based on all the comments, I figure we can just include sys/param.h instead? I made #12123 for that.