Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 1014 failure on FreeBSD 6.2 #12125

Closed
dfandrich opened this issue Oct 15, 2023 · 1 comment
Closed

Test 1014 failure on FreeBSD 6.2 #12125

dfandrich opened this issue Oct 15, 2023 · 1 comment
Labels
build

Comments

@dfandrich
Copy link
Contributor

I did this

This test failues to to curl reporting threadsafe but not curl-config

Mismatch in features lists:
curl:        alt-svc asynchdns ipv6 largefile libz threadsafe unixsockets
curl-config: alt-svc asynchdns ipv6 largefile libz unixsockets
test 1014...[Compare curl --version with curl-config --features]
 1014: postcheck FAILED
== Contents of files in the log/1/ dir after test 1014
=== Start of file server.cmd
 Testnum 1014
=== End of file server.cmd
=== Start of file stdout1014
 curl 8.4.1-DEV (i586-unknown-freebsd6.2) libcurl/8.4.1-DEV zlib/1.2.3
 Release-Date: [unreleased]
 Protocols: dict file ftp gopher http imap mqtt pop3 rtsp smtp telnet tftp
 Features: alt-svc AsynchDNS IPv6 Largefile libz threadsafe UnixSockets
=== End of file stdout1014

The configure test checking for stdatomic.h returns no, which is correct—it doesn't exist. However, pthread.h does exist.

This may be related to #12090.

I expected the following

No test errors.

curl/libcurl version

curl-8.4.0-dev

operating system

FreeBSD 6.2 i386
jay added a commit to jay/curl that referenced this issue Oct 15, 2023
@jay
build: fix 'threadsafe' feature detection for older gcc
8373a27 
- Add 'threadsafe' to the feature list shown during build if POSIX
  threads are being used.

This is a follow-up to 5adb600 which added support for building a
thread-safe libcurl with older versions of gcc where atomic is not
available but pthread is.

Reported-by: Dan Fandrich

Fixes curl#12125
Closes #xxxx
@jay jay mentioned this issue Oct 15, 2023
Closed
@jay
Copy link
Member

jay commented Oct 15, 2023

Please try #12127 in autotools and cmake and see if it says threadsafe in the build results

@jay jay added the build label Oct 15, 2023
jay added a commit to jay/curl that referenced this issue Oct 15, 2023
@jay
build: fix 'threadsafe' feature detection for older gcc
4585c67 
- Add 'threadsafe' to the feature list shown during build if POSIX
  threads are being used.

This is a follow-up to 5adb600 which added support for building a
thread-safe libcurl with older versions of gcc where atomic is not
available but pthread is.

Reported-by: Dan Fandrich

Fixes curl#12125
Closes #xxxx
jay added a commit to jay/curl that referenced this issue Oct 16, 2023
@jay
build: fix 'threadsafe' feature detection for older gcc
2e4a545 
- Add 'threadsafe' to the feature list shown during build if POSIX
  threads are being used.

This is a follow-up to 5adb600 which added support for building a
thread-safe libcurl with older versions of gcc where atomic is not
available but pthread is.

Reported-by: Dan Fandrich

Fixes curl#12125
Closes #xxxx
@jay jay closed this as completed in e160d17 Oct 17, 2023
zuoxiaofeng pushed a commit to zuoxiaofeng/curl that referenced this issue Nov 28, 2023
@jay @zuoxiaofeng
build: fix 'threadsafe' feature detection for older gcc
00b7eea 
- Add 'threadsafe' to the feature list shown during build if POSIX
  threads are being used.

This is a follow-up to 5adb600 which added support for building a
thread-safe libcurl with older versions of gcc where atomic is not
available but pthread is.

Reported-by: Dan Fandrich
Co-authored-by: Dan Fandrich

Fixes curl#12125
Closes curl#12127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix 'threadsafe' feature detection for older gcc jay/curl
2 participants
@dfandrich @jay