New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libssh2 + CURL_DISABLE_DIGEST_AUTH
+ CURL_DISABLE_AWS
build error
#12273
Labels
Comments
CURL_DISABLE_DIGEST_AUTH
+ CURL_DISABLE_AWS
build error
vszakats
added a commit
to vszakats/curl
that referenced
this issue
Nov 15, 2023
…SABLE_AWS` builds HMAC is required by `Curl_sha256it` which is required by `vssh/libssh2.c`. Make sure to compile it. Fixes: ``` [...] In file included from ./curl/_x64-win-ucrt-cmake-llvm-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:310: ./curl/lib/sha256.c:527:42: error: array has incomplete element type 'const struct HMAC_params' 527 | const struct HMAC_params Curl_HMAC_SHA256[] = { | ^ ./curl/lib/curl_sha256.h:34:21: note: forward declaration of 'struct HMAC_params' [...] ``` Fixes curl#12273 Closes #xxxxx
CURL_DISABLE_DIGEST_AUTH
+ CURL_DISABLE_AWS
build errorCURL_DISABLE_DIGEST_AUTH
+ CURL_DISABLE_AWS
build error
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this issue
Nov 28, 2023
Builds with libssh2 + `-DCURL_DISABLE_DIGEST_AUTH=ON` + `-DCURL_DISABLE_AWS=ON` in combination with either Schannel on Windows, or `-DCURL_DISABLE_NTLM=ON` on other operating systems failed while compiling due to a missing HMAC declaration. The reason is that HMAC is required by `lib/sha256.c` which publishes `Curl_sha256it()` which is required by `lib/vssh/libssh2.c` when building for libssh2 v1.8.2 (2019-05-25) or older. Make sure to compile the HMAC bits for a successful build. Both HMAC and `Curl_sha256it()` rely on the same internals, so splitting them into separate sources isn't practical. Fixes: ``` [...] In file included from ./curl/_x64-win-ucrt-cmake-llvm-bld/lib/CMakeFiles/libcurl_object.dir/Unity/unity_0_c.c:310: ./curl/lib/sha256.c:527:42: error: array has incomplete element type 'const struct HMAC_params' 527 | const struct HMAC_params Curl_HMAC_SHA256[] = { | ^ ./curl/lib/curl_sha256.h:34:21: note: forward declaration of 'struct HMAC_params' [...] ``` Regression from e92edfb curl#11490 Fixes curl#12273 Closes curl#12332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did this
Building with:
Results in:
The same happens without Schannel by setting
-DCURL_DISABLE_NTLM=ON
instead.Enabling e.g. quictls, doesn't fix it.
Possibly regression from e92edfb #11490
I expected the following
No error
curl/libcurl version
8.5.0-DEV 46878b9
operating system
any
The text was updated successfully, but these errors were encountered: