New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with semicolon in ftp password #1252

Closed
balcaina opened this Issue Feb 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@balcaina

balcaina commented Feb 7, 2017

I did this

I am using the curl library in my program and I recently upgraded from version 7.21.4 to version 7.50.1 and I noticed a behavior change with semicolon in ftp password for example when using the URL "ftp://user:pass;word@example.com"

I expected the following

I expected my program to use "user" and "pass;word" for authentication when using the URL "ftp://user:pass;word@example.com" but instead I have "user" and "pass".

With curl 7.21.4, the URL "ftp://user:pass;word@example.com" was giving "user" and "pass;word" for authentication.

curl/libcurl version

curl -V
curl 7.50.1 (x86_64-pc-linux-gnu) libcurl/7.50.1 OpenSSL/1.0.2h zlib/1.2.5 c-ares/1.7.5
Protocols: file ftp ftps http https smb smbs smtp smtps
Features: AsynchDNS Largefile NTLM NTLM_WB SSL libz UnixSockets

operating system

uname -r
3.16.0-4-amd64

@bagder bagder self-assigned this Feb 7, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 7, 2017

Member

Agreed. Regression brought by 73aa955. The semicolon (and the associated option it was added for) should not be treated like this for FTP:// URLs.

Semicolons are sub-delims according to RFC3986 which allows them to serve as delimiters for scheme-specific things, but there's no such field for FTP there and thus it should be allowed...

Member

bagder commented Feb 7, 2017

Agreed. Regression brought by 73aa955. The semicolon (and the associated option it was added for) should not be treated like this for FTP:// URLs.

Semicolons are sub-delims according to RFC3986 which allows them to serve as delimiters for scheme-specific things, but there's no such field for FTP there and thus it should be allowed...

@bagder bagder added the URL label Feb 7, 2017

@bagder bagder closed this in c5c4e81 Feb 10, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 10, 2017

Member

thanks for your report!

Member

bagder commented Feb 10, 2017

thanks for your report!

@balcaina

This comment has been minimized.

Show comment
Hide comment
@balcaina

balcaina Feb 10, 2017

Thanks for the fix !

balcaina commented Feb 10, 2017

Thanks for the fix !

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.