Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarballs are missing files #12914

Closed
Vogtinator opened this issue Feb 9, 2024 · 0 comments
Closed

Tarballs are missing files #12914

Vogtinator opened this issue Feb 9, 2024 · 0 comments
Assignees
Labels

Comments

@Vogtinator
Copy link

I did this

I cherry-picked ed09a99 to 8.6.0 to apply it to the tarball during build.

However, it fails to apply because various files are missing in the tarball:

[   31s] |diff --git a/tests/http/test_05_errors.py b/tests/http/test_05_errors.py
[   31s] |index b59f3f177..68e49f736 100644
[   31s] |--- a/tests/http/test_05_errors.py
[   31s] |+++ b/tests/http/test_05_errors.py
[   31s] --------------------------
[   31s] No file to patch.  Skipping patch.
[   31s] 1 out of 1 hunk ignored
[   31s] The text leading up to this was:
[   31s] --------------------------
[   31s] |diff --git a/tests/http/testenv/httpd.py b/tests/http/testenv/httpd.py
[   31s] |index 79497c5b3..c04c22699 100644
[   31s] |--- a/tests/http/testenv/httpd.py
[   31s] |+++ b/tests/http/testenv/httpd.py
[   31s] --------------------------
[   31s] No file to patch.  Skipping patch.
[   31s] 2 out of 2 hunks ignored
[   31s] The text leading up to this was:
[   31s] --------------------------
[   31s] |diff --git a/tests/http/testenv/mod_curltest/mod_curltest.c b/tests/http/testenv/mod_curltest/mod_curltest.c
[   31s] |index ff1983d17..a066be522 100644
[   31s] |--- a/tests/http/testenv/mod_curltest/mod_curltest.c
[   31s] |+++ b/tests/http/testenv/mod_curltest/mod_curltest.c
[   31s] --------------------------
[   31s] No file to patch.  Skipping patch.
[   31s] 1 out of 1 hunk ignored

Indeed, they are missing:

> tar tvf curl-8.6.0.tar.xz | grep tests/http
drwxr-xr-x 1000/1000         0 2024-01-31 08:04 curl-8.6.0/tests/http/
drwxr-xr-x 1000/1000         0 2024-01-31 08:04 curl-8.6.0/tests/http/clients/
-rw-r--r-- 1000/126       7389 2023-12-08 14:25 curl-8.6.0/tests/http/clients/ws-data.c
-rw-r--r-- 1000/1000      9007 2024-01-23 16:21 curl-8.6.0/tests/http/clients/h2-download.c
-rw-r--r-- 1000/126       7385 2023-12-08 14:25 curl-8.6.0/tests/http/clients/h2-upgrade-extreme.c
-rw-r--r-- 1000/1000     30792 2024-01-29 16:53 curl-8.6.0/tests/http/clients/Makefile.in
-rw-r--r-- 1000/126       1222 2023-12-08 14:25 curl-8.6.0/tests/http/clients/Makefile.inc
-rw-r--r-- 1000/126       4195 2023-12-08 14:25 curl-8.6.0/tests/http/clients/ws-pingpong.c
-rw-r--r-- 1000/126       2282 2023-12-08 14:25 curl-8.6.0/tests/http/clients/Makefile.am
-rw-r--r-- 1000/1000      7283 2024-01-23 16:21 curl-8.6.0/tests/http/clients/h2-serverpush.c
-rw-r--r-- 1000/126       9654 2023-12-08 14:25 curl-8.6.0/tests/http/clients/h2-pausing.c
-rw-r--r-- 1000/126       8597 2023-12-08 14:25 curl-8.6.0/tests/http/clients/tls-session-reuse.c
-rw-r--r-- 1000/126       1181 2023-12-08 14:25 curl-8.6.0/tests/http/config.ini.in
-rw-r--r-- 1000/1000     24266 2024-01-29 16:53 curl-8.6.0/tests/http/Makefile.in
-rw-r--r-- 1000/126       7477 2023-12-08 14:25 curl-8.6.0/tests/http/README.md
-rw-r--r-- 1000/126       1191 2023-12-08 14:25 curl-8.6.0/tests/http/Makefile.am
-rwxr-xr-x 1000/126       5115 2023-12-08 14:25 curl-8.6.0/tests/http-server.pl
-rwxr-xr-x 1000/126       3394 2023-12-08 14:25 curl-8.6.0/tests/http2-server.pl
-rwxr-xr-x 1000/126       3374 2023-12-08 14:25 curl-8.6.0/tests/http3-server.pl

I guess they are not part of the make dist target.

I expected the following

No response

curl/libcurl version

8.6.0

operating system

openSUSE Tumbleweed

@bagder bagder added the dist label Feb 9, 2024
@bagder bagder self-assigned this Feb 9, 2024
bagder added a commit that referenced this issue Feb 9, 2024
@bagder bagder closed this as completed in d0a851f Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants