Skip to content

Issue while building curl with wolfssl #13115

Description

@devkdas

I did this

i built wolfssl and curl using below
https://github.com/curl/curl/blob/master/docs/HTTP3.md#build-with-wolfssl



### I expected the following

expected to build curl with wolfssl

curl/libcurl version

root@ubuntu:/src/curl_wolfssl# curl -V
curl 7.81.0 (x86_64-pc-linux-gnu) libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.1.0 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.16
Release-Date: 2022-01-05
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets zstd
root@ubuntu:/src/curl_wolfssl#

### operating system

root@ubuntu:/src/curl_wolfssl# uname -a
Linux ubuntu 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
root@ubuntu:/src/curl_wolfssl#

Activity

  1. devkdas commented on Mar 13, 2024

    @devkdas
    ContributorAuthor
    root@ubuntu:/src/curl_wolfssl# git log
    commit aedbbdf18e689a5eee8dc39600914f5eda6c409c (HEAD -> master, origin/master, origin/HEAD)
    Author: Daniel Stenberg <daniel@haxx.se>
    Date:   Mon Mar 11 10:53:08 2024 +0100
    
        vquic-tls: return appropirate errors on wolfSSL errors
    
        Reported-by: Dexter Gerig
        Closes #13107
    
    commit 14d9afdfe72935df1078a97936e6406ee3e0a824
    Author: Viktor Szakats <commit@vsz.me>
    Date:   Tue Mar 12 12:04:27 2024 +0000
    
        tidy-up: one comment and EOF newlines
    
        Reviewed-by: Daniel Stenberg
        Closes #13108
    
  2. devkdas commented on Mar 13, 2024

    @devkdas
    ContributorAuthor
      CC       vquic/libcurl_la-vquic-tls.lo
    vquic/vquic-tls.c: In function ‘curl_wssl_init_ctx’:
    vquic/vquic-tls.c:420:18: error: ‘CURLE_SSL_CACERT’ undeclared (first use in this function); did you mean ‘CURLE_SSL_CIPHER’?
      420 |         result = CURLE_SSL_CACERT;
          |                  ^~~~~~~~~~~~~~~~
          |                  CURLE_SSL_CIPHER
    vquic/vquic-tls.c:420:18: note: each undeclared identifier is reported only once for each function it appears in
    make[2]: *** [Makefile:3348: vquic/libcurl_la-vquic-tls.lo] Error 1
    make[2]: Leaving directory '/src/curl_wolfssl/lib'
    make[1]: *** [Makefile:1535: all] Error 2
    make[1]: Leaving directory '/src/curl_wolfssl/lib'
    make: *** [Makefile:1266: all-recursive] Error 1
    root@ubuntu:/src/curl_wolfssl#
    root@ubuntu:/src/curl_wolfssl#
    
  3. devkdas commented on Mar 13, 2024

    @devkdas
    ContributorAuthor
    root@ubuntu:/src/curl_wolfssl# ./src/curl -V
    curl 8.7.0-DEV (x86_64-pc-linux-gnu) libcurl/8.7.0-DEV wolfSSL/5.6.6 zlib/1.2.11 brotli/1.1.0 libidn2/2.3.2 libpsl/0.21.0 nghttp2/1.43.0 ngtcp2/1.2.0 nghttp3/1.1.0 OpenLDAP/2.5.16
    Release-Date: [unreleased]
    Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp smtp smtps telnet tftp
    Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 IDN IPv6 Largefile libz PSL SSL threadsafe UnixSockets
    root@ubuntu:/src/curl_wolfssl#
    
    root@ubuntu:/src/curl_wolfssl# git log
    commit 14d9afdfe72935df1078a97936e6406ee3e0a824 (HEAD)
    Author: Viktor Szakats <commit@vsz.me>
    Date:   Tue Mar 12 12:04:27 2024 +0000
    
        tidy-up: one comment and EOF newlines
    
        Reviewed-by: Daniel Stenberg
        Closes #13108
    
    

    commit which broke functanility with wolf ssl is
    aedbbdf

  4. jay commented on Mar 13, 2024

    @jay
    Member

    He must have meant CURLE_SSL_CACERT_BADFILE. I fixed it. Thanks

  5. devkdas commented on Mar 13, 2024

    @devkdas
    ContributorAuthor

    Thanks @jay

  6. bagder commented on Mar 13, 2024

    @bagder
    Member

    Clearly. I was mistakenly thinking we had a CI job that verified that change/build... 😞

  7. jay commented on Mar 13, 2024

    @jay
    Member

    Clearly. I was mistakenly thinking we had a CI job that verified that change/build... 😞

    We do and it failed

  8. bagder commented on Mar 13, 2024

    @bagder
    Member

    bah, then I was just even more blind than usual...

  9. jay commented on Mar 13, 2024

    @jay
    Member

    ci fatigue it happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions