-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiche CI job occasionally fails during a download abort test #13439
Comments
According to testclutch, the first quiche pytest failures started with https://github.com/curl/curl/actions/runs/8715610798, which was commit 5b94ece - which seems totally innocuous and unrelated... I'm puzzled. |
neat
Yeah that's the first one but notice the quiche job does not always fail, so it's possible the failures have been caused by a parent whose quiche job completed successfully. |
Looking at this now. What happened is that the test client changed and seems to expose a timing related bug in the quiche handling. |
- when a connection close is detected, all ongoing transfers need to expire bc no more POLL events are likely to happen for them. - refs curl#13439
I was not able to reproduce locally, but I found in the logs that quiche
This maybe the cause of all the failures. Why exactly the connection is considered closed, I do not know. I added some log statement to at least see if it is related to the idle timer. But the overall log times do not suggest this being the case. |
Unfortunately, this issue seems to remain even after #13447 |
This seems to no longer trigger that often. I propose we close. |
Ok. Possibly this is a valid corner case bug and not just CI weirdness by itself but I can't be sure |
For the last few days there are occasional CI failures in the quiche job. It is hard to diagnose them because the logs are so large due to millions of "curl_multi_poll() -> 0" output (from h2-download.c). The output is truncated and downloading the raw archive fails repeatedly.
The most recent commit to have the failure: "http: acknowledge a returned error code". After repeated attempts github finally gave me the whole file. I stripped out most of the excess
curl_multi_poll() -> 0
to make it readable: log.txt. Excerpt:Probably related to 08d10d2 even though its quiche job passed. I'm not finding failures before then and I don't know what else it could be.
/cc @icing
The text was updated successfully, but these errors were encountered: