Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HEAD requests fail with: HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR #13725

Closed
jeroen opened this issue May 20, 2024 · 2 comments
Closed

HEAD requests fail with: HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR #13725

jeroen opened this issue May 20, 2024 · 2 comments
Assignees
@icing
Labels
HTTP/2

Comments

@jeroen
Copy link
Contributor

jeroen commented May 20, 2024 •
edited
Loading

Users of the R bindings found that after a recent libcurl update, the following started failing:

curl --compressed -IL "http://www.dropbox.com/s/srkb2ife75px2yz/modeling_results_BayesSpace_k09.Rdata?dl=1"
# HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR (

If we disable HTTP/2 the request also errors but with chunk hex-length char not a hex digit: 0x1f error:

curl --compressed  -IL --http1.1 "http://www.dropbox.com/s/srkb2ife75px2yz/modeling_results_BayesSpace_k09.Rdata?dl=1"
# chunk hex-length char not a hex digit: 0x1f

curl/libcurl version

I confirmed the problem started appearing on curl 8.6.0 and 8.7.1 on MacOS.

I also confirmed the problem did not appear on curl 8.4.0 on MacOS.

operating system

MacOS
@jeroen jeroen mentioned this issue May 20, 2024
Closed
@lcolladotor lcolladotor mentioned this issue May 20, 2024
Closed
@bagder bagder added the HTTP/2 label May 21, 2024
@icing icing self-assigned this May 21, 2024
@jeroen
Copy link
Contributor Author

jeroen commented May 21, 2024

FYI it is not just http/2 it also happens with http 1.1.

@icing
Copy link
Contributor

icing commented May 21, 2024 •
edited
Loading

The server sends a response to the HEAD request which includes bytes after the headers. This is invalid HTTP (in 1.1 and 2). curl 8.4 ignored these bytes with a warning while 8.6 and newer fail.

I made #13732 to fix this.

icing added a commit to icing/curl that referenced this issue May 21, 2024
@icing
HEAD response body tolerance
f052018 
- as reported in curl#13725, some servers wrongly send body bytes in
  responses to a HEAD request. This used to be tolerated in curl
  8.4 and before and leads to failed transfers in newer versions.
- restore previous behaviour for HTTP/1.1 and HTTP/2:
  * 1.1: do not add 'Transfer-Encoding' writers from HEAD
    responses. RFC 9112 says they do not apply.
  * 2: when the transfer expects 'no_body', to not report stream
    resets as error when all response headers have been received.
@icing icing mentioned this issue May 21, 2024
Closed
@bagder bagder closed this as completed in 5a4769b May 21, 2024
icing added a commit to icing/curl that referenced this issue May 21, 2024
@icing
add test1484, for HEAD with content
9e8a604 
- test HEAD request with 'Transfer-Encoding:chunked' and
  non-encoded response content
- verifies curl#13725
@icing icing mentioned this issue May 21, 2024
Closed
bagder pushed a commit that referenced this issue May 22, 2024
@icing @bagder
test: add test1484, for HEAD with content
5e403df 
- test HEAD request with 'Transfer-Encoding:chunked' and
  non-encoded response content
- verifies #13725

Closes #13735
lcolladotor added a commit to lcolladotor/cshl_rstats_genome_scale_2024 that referenced this issue Jun 6, 2024
@lcolladotor
Try to address the issue with curl version 8.6.0 on macOS Sonoma 14.5…
de7f229 
… by installing curl version 8.8.0 with Homebrew (brew install curl) + compiling the curl R package from source.

Related to curl/curl#13725, Bioconductor/BiocFileCache#48, and other issues.
@lcolladotor lcolladotor mentioned this issue Jun 11, 2024
Open
@lcolladotor lcolladotor mentioned this issue Jul 18, 2024
Open
@lcolladotor lcolladotor mentioned this issue Aug 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
HTTP/2
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icing @bagder @jeroen