Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong time units of TCP keepalive options on DragonFlyBSD 5.8+ #13847

Closed
panjf2000 opened this issue Jun 1, 2024 · 0 comments
Closed

Wrong time units of TCP keepalive options on DragonFlyBSD 5.8+ #13847

panjf2000 opened this issue Jun 1, 2024 · 0 comments

Comments

@panjf2000
Copy link
Contributor

panjf2000 commented Jun 1, 2024

I did this

DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8.

Setting the keepalive options with milliseconds with curl/libcurl will result in unexpected behaviors on DragonFlyBSD 5.8+

References

I expected the following

Distinguish the DragonFly BSD versions and use the proper time units accordingly.

curl/libcurl version

master branch

operating system

DragonflyBSD 5.8+

panjf2000 added a commit to panjf2000/curl that referenced this issue Jun 1, 2024
DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8,
thus setting the keepalive options with milliseconds with curl/libcurl will result in unexpected
behaviors on DragonFlyBSD 5.8+

Distinguish the DragonFly BSD versions and use the proper time units accordingly.

Ref:
  https://lists.dragonflybsd.org/pipermail/commits/2019-July/719125.html
  https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e960908836b97aa034fa2753091e0172e/sys/sys/param.h#L207

Fixes curl#13847
panjf2000 added a commit to panjf2000/curl that referenced this issue Jun 1, 2024
DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8,
thus setting the keepalive options with milliseconds with curl/libcurl will result in unexpected
behaviors on DragonFlyBSD 5.8+

Distinguish the DragonFly BSD versions and use the proper time units accordingly.

Ref:
  https://lists.dragonflybsd.org/pipermail/commits/2019-July/719125.html
  https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e960908836b97aa034fa2753091e0172e/sys/sys/param.h#L207

Fixes curl#13847
@bagder bagder closed this as completed in 6da3203 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant