Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools: pkgconf can't find zstd #14005

Closed
L4cache opened this issue Jun 24, 2024 · 3 comments
Closed

autotools: pkgconf can't find zstd #14005

L4cache opened this issue Jun 24, 2024 · 3 comments

Comments

@L4cache
Copy link

L4cache commented Jun 24, 2024

I did this

Use media-autobuild_suite to build mediainfo, and during configure, mediainfo can't find zstd required by libcurl required by libmediainfo.
There's libzstd.pc, but libcurl.pc file generated by autoconf uses "zstd" in Requires.private, pkgconf can't find it. CMake on the other hand uses "libzstd", so maybe it's a typo in configure.ac?

More detail: m-ab-s/media-autobuild_suite#2723

f057de5#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810R1562

f057de5#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR606

I expected the following

No response

curl/libcurl version

curl 8.9.0-DEV

operating system

MSYS2

@L4cache L4cache changed the title CMake and autoconf use different zstd name in libcurl.pc Pkgconf can't find zstd Jun 24, 2024
@L4cache
Copy link
Author

L4cache commented Jun 24, 2024

I think I should change the title because the problem is not exactly about the difference.

@vszakats
Copy link
Member

Nice that you spotted that, cmake and autotools should definitely use the same name here.

I'll open a PR for this shortly.

vszakats added a commit to vszakats/curl that referenced this issue Jun 24, 2024
Also verified that all now match up with CMake.

Reported-by: 李四 (zstd)
Ref: curl#14005
Follow-up to f057de5 curl#13911
Closes #xxxxx
@vszakats vszakats changed the title Pkgconf can't find zstd autotools: pkgconf can't find zstd Jun 24, 2024
@vszakats
Copy link
Member

@L4cache Thanks for your report. Please open a new Issue if this persist after the merged fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants