-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Stray characters beyond COLUMNS with -# after a redirect #14213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Thanks for showing how to easily reproduce. |
bagder
added a commit
that referenced
this issue
Jul 20, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes #14213
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this issue
Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this issue
Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this issue
Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this issue
Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246
meslubi2021
pushed a commit
to Unity-Curl/curl
that referenced
this issue
Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Jul 24, 2024
* tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Jul 24, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Jul 24, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Jul 24, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Jul 24, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Aug 10, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * develop (#316) * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Aug 10, 2024
* Create cmake-multi-platform.yml * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * develop (#317) * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Co-authored-by: بلال مسلوب <145295387+mesloubi2021@users.noreply.github.com> Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Aug 10, 2024
* Create c-cpp.yml * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * develop (#318) * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Co-authored-by: بلال مسلوب <145295387+mesloubi2021@users.noreply.github.com> Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021
added a commit
to Unity-Curl/curl
that referenced
this issue
Aug 10, 2024
* multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * develop (#319) * multi: do a final progress update on connect failure To fix timing metric etc Co-authored-by: Justin Maggard Fixes curl#14204 Closes curl#14239 * CURLOPT_SSL_VERIFYHOST.md: refresh Move mentions of old behavior to the HISTORY section to make it easier to read about modern behavior. Added a MATCHING section. Closes curl#14241 * lib: Curl_posttransfer => multi_posttransfer Moved from transfer.c to multi.c as it was only used within multi.c Made a void, as it returned a fixed return code nothing checked. Closes curl#14240 * tool_cb_prg: output "flying saucers" with leading carriage return Because that is how the progress-bar is output, so when the progress-bar has been shown at least once and the information is reset, like for a redirect, there might be a moment where the size goes from known to unknown and then the flying saucerts are shown after a brief display of the progress-bar. It could previously cause accidental character leftovers on the right side of the bar when using a narrow display. Reported-by: Chris Webb Fixes curl#14213 Closes curl#14246 * conncache: connection shutdown, multi_socket handling - implement the socket hash user/reader/writer processing also for connections that are being shut down by the connection cache. - split out handling of current vs. last pollset socket event handling into a function available in other code parts - add `shutdown_poll` pollset to `connectdata` struct so that changes in the pollset can be recorded during shutdown. (The internal handle cannot keep it since it might be used for many connections) Reported-by: calvin2021y on github Fixes curl#14252 Closes curl#14257 * GHA: bump github/codeql-action from 3.25.11 to 3.25.13 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b611370...2d79040) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Closes curl#14255 * docs/libcurl: add to cleanup docs that their inputs go invalid Reported-by: icy17 on github Fixes curl#14248 Closes curl#14258 * curl_easy_escape.md: move historic details to HISTORY Closes curl#14261 * THANKS: updates from the 8.9.0 release * RELEASE-NOTES: synced * RELEASE-PROCEDURE.md: remove the initial build step Because it is no longer needed to be done by a person as the dmaketgz script does it by itself. Removed two past release dates, added two new future ones Closes curl#14267 * RELEASE-NOTES: synced bumped to 8.9.1 * RELEASE-PROCEDURE.md: restore next release date Pointed-out-by: extrimexxx on github Bug: curl#14267 (comment) --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Co-authored-by: Daniel Stenberg <daniel@haxx.se> Co-authored-by: Stefan Eissing <stefan@eissing.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did this
Fetch a file via a redirect with
-#
and-L
. Specify a smallish COLUMNS to make the symptoms clearer:Capturing the output with COLUMNS=32 (for a multiple of 16) and hexdumping, it's a bit clearer what's happened:
There seem to be two
\r
characters before the 100% bar and none after it, rather than one before it and one after.I can only reproduce this behaviour with a redirect and -L.
I expected the following
Progress bar output restricted to COLUMNS characters per line, without stray characters beyond this point, presumably a single
\r
before the###=-
is output.curl/libcurl version
operating system
My own machine, on which I originally spotted this:
However, I have also reproduced this with the Debian packaged curl 7.88.1-10+deb12u5 on a glibc 2.36.9 machine, to confirm it's not a bug in musl stdio.h.
The text was updated successfully, but these errors were encountered: