Skip to content

Stray characters beyond COLUMNS with -# after a redirect #14213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arachsys opened this issue Jul 17, 2024 · 1 comment
Closed

Stray characters beyond COLUMNS with -# after a redirect #14213

arachsys opened this issue Jul 17, 2024 · 1 comment
Assignees

Comments

@arachsys
Copy link
Contributor

I did this

Fetch a file via a redirect with -# and -L. Specify a smallish COLUMNS to make the symptoms clearer:

# COLUMNS=40 curl -o /dev/null -L -# https://www.kernel.org/pub/linux/kernel/v6.x/linux-6.10.tar.xz
################                   48.8%###=-

Capturing the output with COLUMNS=32 (for a multiple of 16) and hexdumping, it's a bit clearer what's happened:

00000000  23 23 4f 3d 2d 20 20 20  20 20 20 20 20 20 20 20  |##O=-           |
00000010  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000020  0d 0d 23 23 23 23 23 23  23 23 23 23 23 23 23 23  |..##############|
00000030  23 23 23 23 23 23 23 23  23 23 23 20 31 30 30 2e  |########### 100.|
00000040  30 25 23 23 23 3d 2d 20  20 20 20 20 20 20 20 20  |0%###=-         |
00000050  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000060  20 20 0d 0d 20 20 20 20  20 20 20 20 20 20 20 20  |  ..            |
00000070  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000080  30 2e 31 25 0d 20 20 20  20 20 20 20 20 20 20 20  |0.1%.           |
00000090  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
000000a0  20 30 2e 35 25 0d 20 20  20 20 20 20 20 20 20 20  | 0.5%.          |
000000b0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
000000c0  20 20 31 2e 30 25 0d 20  20 20 20 20 20 20 20 20  |  1.0%.         |
000000d0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
000000e0  20 20 20 31 2e 34 25 0d  20 20 20 20 20 20 20 20  |   1.4%.        |
000000f0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000100  20 20 20 20 31 2e 39 25  0d 20 20 20 20 20 20 20  |    1.9%.       |
00000110  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000120  20 20 20 20 20 32 2e 34  25 0d 20 20 20 20 20 20  |     2.4%.      |
00000130  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |

There seem to be two \r characters before the 100% bar and none after it, rather than one before it and one after.

I can only reproduce this behaviour with a redirect and -L.

I expected the following

Progress bar output restricted to COLUMNS characters per line, without stray characters beyond this point, presumably a single \r before the ###=- is output.

curl/libcurl version

$ curl --version
curl 8.8.0 (x86_64-arachsys-linux-musl) libcurl/8.8.0 LibreSSL/3.9.2 zlib/1.3.1 zstd/1.5.6 libpsl/0.21.5 nghttp2/1.62.1
Release-Date: 2024-05-22
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS HSTS HTTP2 HTTPS-proxy IPv6 Largefile libz NTLM PSL SSL threadsafe UnixSockets zstd

operating system

My own machine, on which I originally spotted this:

$ uname -a
Linux xi 6.10 #1 SMP PREEMPT Wed Jul 17 15:55:48 BST 2024 x86_64 GNU/Linux

However, I have also reproduced this with the Debian packaged curl 7.88.1-10+deb12u5 on a glibc 2.36.9 machine, to confirm it's not a bug in musl stdio.h.

@bagder bagder self-assigned this Jul 20, 2024
@bagder
Copy link
Member

bagder commented Jul 20, 2024

Thanks for showing how to easily reproduce.

bagder added a commit that referenced this issue Jul 20, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes #14213
@bagder bagder closed this as completed in 8193ca5 Jul 22, 2024
meslubi2021 pushed a commit to Unity-Curl/curl that referenced this issue Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246
meslubi2021 pushed a commit to Unity-Curl/curl that referenced this issue Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246
meslubi2021 pushed a commit to Unity-Curl/curl that referenced this issue Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246
meslubi2021 pushed a commit to Unity-Curl/curl that referenced this issue Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246
meslubi2021 pushed a commit to Unity-Curl/curl that referenced this issue Jul 22, 2024
Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Jul 24, 2024
* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Jul 24, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Jul 24, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Jul 24, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Jul 24, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Aug 10, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* develop (#316)

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Aug 10, 2024
* Create cmake-multi-platform.yml

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* develop (#317)

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Co-authored-by: بلال مسلوب <145295387+mesloubi2021@users.noreply.github.com>
Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Aug 10, 2024
* Create c-cpp.yml

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* develop (#318)

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Co-authored-by: بلال مسلوب <145295387+mesloubi2021@users.noreply.github.com>
Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meslubi2021 added a commit to Unity-Curl/curl that referenced this issue Aug 10, 2024
* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* develop (#319)

* multi: do a final progress update on connect failure

To fix timing metric etc

Co-authored-by: Justin Maggard
Fixes curl#14204
Closes curl#14239

* CURLOPT_SSL_VERIFYHOST.md: refresh

Move mentions of old behavior to the HISTORY section to make it easier
to read about modern behavior.

Added a MATCHING section.

Closes curl#14241

* lib: Curl_posttransfer => multi_posttransfer

Moved from transfer.c to multi.c as it was only used within multi.c

Made a void, as it returned a fixed return code nothing checked.

Closes curl#14240

* tool_cb_prg: output "flying saucers" with leading carriage return

Because that is how the progress-bar is output, so when the progress-bar
has been shown at least once and the information is reset, like for a
redirect, there might be a moment where the size goes from known to
unknown and then the flying saucerts are shown after a brief display of
the progress-bar.

It could previously cause accidental character leftovers on the right
side of the bar when using a narrow display.

Reported-by: Chris Webb
Fixes curl#14213
Closes curl#14246

* conncache: connection shutdown, multi_socket handling

- implement the socket hash user/reader/writer processing also
  for connections that are being shut down by the connection cache.
- split out handling of current vs. last pollset socket event handling
  into a function available in other code parts
- add `shutdown_poll` pollset to `connectdata` struct so that changes
  in the pollset can be recorded during shutdown. (The internal handle
  cannot keep it since it might be used for many connections)

Reported-by: calvin2021y on github
Fixes curl#14252
Closes curl#14257

* GHA: bump github/codeql-action from 3.25.11 to 3.25.13

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@b611370...2d79040)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Closes curl#14255

* docs/libcurl: add to cleanup docs that their inputs go invalid

Reported-by: icy17 on github
Fixes curl#14248
Closes curl#14258

* curl_easy_escape.md: move historic details to HISTORY

Closes curl#14261

* THANKS: updates from the 8.9.0 release

* RELEASE-NOTES: synced

* RELEASE-PROCEDURE.md: remove the initial build step

Because it is no longer needed to be done by a person as the dmaketgz
script does it by itself.

Removed two past release dates, added two new future ones

Closes curl#14267

* RELEASE-NOTES: synced

bumped to 8.9.1

* RELEASE-PROCEDURE.md: restore next release date

Pointed-out-by: extrimexxx on github
Bug: curl#14267 (comment)

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Co-authored-by: Daniel Stenberg <daniel@haxx.se>
Co-authored-by: Stefan Eissing <stefan@eissing.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants