Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure no longer errors when libpsl is not found and not explicitly disabled #14373

Closed
ryandesign opened this issue Aug 4, 2024 · 1 comment
Assignees

Comments

@ryandesign
Copy link
Contributor

I did this

./configure --without-ssl

I expected the following

configure: error: libpsl was not found

curl/libcurl version

8.9.1

operating system

macOS 12

@ryandesign
Copy link
Contributor Author

Your bug reporting template is cumbersome because it has no place to add additional comments.

A big deal was made about how curl 8.6.0 would now fail to configure if libpsl was not found and not explicitly disabled:

% ./configure --without-ssl
...
checking for library containing psl_builtin... no
configure: error: libpsl was not found

That feature appears to have gone away in curl 8.7.0 when the libpsl detection was rewritten to use pkg-config in 9b3f67e. It no longer fails when libpsl is not found even when libpsl is not explicitly disabled:

% ./configure --without-ssl
...
checking for psl_builtin in -lpsl... no
...
configure: Configured to build curl/libcurl:
...
  PSL:              no      (--with-libpsl)

@vszakats vszakats added the build label Aug 4, 2024
@bagder bagder self-assigned this Aug 4, 2024
bagder added a commit that referenced this issue Aug 4, 2024
Regression since 9b3f67e (shipped in 8.7.0)
Reported-by: Ryan Carsten Schmidt
Fixes #14373
@bagder bagder closed this as completed in ed28504 Aug 5, 2024
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 1, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 1, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 7, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379

(cherry picked from commit e0b8bf3)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 7, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379

(cherry picked from commit b333f10)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 7, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379

(cherry picked from commit e0b8bf3)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 7, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379

(cherry picked from commit b333f10)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 8, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379

(cherry picked from commit e0b8bf3)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 8, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379

(cherry picked from commit b333f10)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 8, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379

(cherry picked from commit b333f10)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 8, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379

(cherry picked from commit e0b8bf3)
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 9, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 9, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 9, 2024
added --without-psl per information at:
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
curl/curl#14373
curl/curl#14379
craigcomstock added a commit to craigcomstock/buildscripts that referenced this issue Oct 9, 2024
Adjusted for libcurl 8.10.0 change: configure: fail if PSL is not disabled but not found.
added --without-psl per information at:
curl/curl#14373
curl/curl#14379
emasab added a commit to confluentinc/librdkafka that referenced this issue Oct 31, 2024
* Security upgrade for OpenSSL and Curl, CVEs fixed:

OpenSSL
- CVE-2024-2511
- CVE-2024-4603
- CVE-2024-4741
- CVE-2024-5535
- CVE-2024-6119

CURL
- CVE-2024-8096
- CVE-2024-7264
- CVE-2024-6874
- CVE-2024-6197

* Fix for curl configure failure caused by
curl/curl#14373
anchitj added a commit to confluentinc/librdkafka that referenced this issue Dec 15, 2024
* Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (#4438)

* Remove CentOS 6 and CentOS 7 binaries (#4775)

*Remove CentOS 6 and 7 support as discontinued, keeps
  using manylinux_2_28 based on AlmaLinux 8 (CentOS 8)
* Remove fix for CentOS 6
* Add CHANGELOG entry
* Upgrade test and verify package creation or installation
   using clients repository

* Upgrade msvcr140 and vcpkg dependencies (#4872)

* Add forward declaration to fix compilation without ssl (#4794)

and add build checks with different configurations

* PR comments

* Add files for lz4 1.9.4 (#4726)

* Add files for lz4 1.9.4

* Update changelog.md

* rdxxhash should not be in clang-format list

* Add instructions and update memory alloc/free

* Update instructions for lz4

* NONJAVACLI-3460: update dependencies (#4706)

* update third party dependencies
* update lz4 version in the header file
* update libraries for the windows build
* reverting the version bump in the headers
* use the latest version of curl
* Update OpenSSL and add CHANGELOG.md
* downgade curl version to one available via vcpkg
* downgrade zlib to last available version in vcpkg
* downgrade zstd to the latest available
* Include CPPFLAGS within make for libcurl
* Update mklove/modules/configure.libcurl
* Update CHANGELOG.md

---------

Co-authored-by: Milind L <miluthra@confluent.io>
Co-authored-by: Emanuele Sabellico <esabellico@confluent.io>

* Upgrade linux dependencies (#4875)

* Security upgrade for OpenSSL and Curl, CVEs fixed:

OpenSSL
- CVE-2024-2511
- CVE-2024-4603
- CVE-2024-4741
- CVE-2024-5535
- CVE-2024-6119

CURL
- CVE-2024-8096
- CVE-2024-7264
- CVE-2024-6874
- CVE-2024-6197

* Fix for curl configure failure caused by
curl/curl#14373

* Include NOTE in CHANGELOG

* Update RD_KAFKA_VERSION in rdkafkacpp.h

---------

Co-authored-by: Emanuele Sabellico <esabellico@confluent.io>
Co-authored-by: Milind L <milindl@users.noreply.github.com>
Co-authored-by: Jan Werner <105367074+janjwerner-confluent@users.noreply.github.com>
Co-authored-by: Milind L <miluthra@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants