Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure no longer errors when libpsl is not found and not explicitly disabled #14373

Closed
ryandesign opened this issue Aug 4, 2024 · 1 comment
Assignees

Comments

@ryandesign
Copy link
Contributor

I did this

./configure --without-ssl

I expected the following

configure: error: libpsl was not found

curl/libcurl version

8.9.1

operating system

macOS 12

@ryandesign
Copy link
Contributor Author

Your bug reporting template is cumbersome because it has no place to add additional comments.

A big deal was made about how curl 8.6.0 would now fail to configure if libpsl was not found and not explicitly disabled:

% ./configure --without-ssl
...
checking for library containing psl_builtin... no
configure: error: libpsl was not found

That feature appears to have gone away in curl 8.7.0 when the libpsl detection was rewritten to use pkg-config in 9b3f67e. It no longer fails when libpsl is not found even when libpsl is not explicitly disabled:

% ./configure --without-ssl
...
checking for psl_builtin in -lpsl... no
...
configure: Configured to build curl/libcurl:
...
  PSL:              no      (--with-libpsl)

@vszakats vszakats added the build label Aug 4, 2024
@bagder bagder self-assigned this Aug 4, 2024
bagder added a commit that referenced this issue Aug 4, 2024
Regression since 9b3f67e (shipped in 8.7.0)
Reported-by: Ryan Carsten Schmidt
Fixes #14373
@bagder bagder closed this as completed in ed28504 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants