Repository navigation
OpenSSL-QUIC: memory leak when downgrading from HTTP/3 #14720
Description
I did this
This minimum code generates a memory leak:
curl_easy_setopt(easy_handle, CURLOPT_SSL_VERIFYPEER, 0);
curl_easy_setopt(easy_handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_3);
curl_easy_setopt(easy_handle, CURLOPT_URL, "https://www.strato.de/");
curl_easy_perform(easy_handle);It is important that the server does not run HTTP/3 to force curl to downgrade. Without the downgrade (that said, no CURL_HTTP_VERSION_3), there is no leak.
The leak was introduced in cb17c06.
This patch fixes the leak, but I did not otherwise test for correctness or unwanted side effects.
lib/vquic/curl_osslq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/vquic/curl_osslq.c b/lib/vquic/curl_osslq.c
index 31469c8d43..229512a7f5 100644
--- a/lib/vquic/curl_osslq.c
+++ b/lib/vquic/curl_osslq.c
@@ -434,6 +434,7 @@ static void cf_osslq_destroy(struct Curl_cfilter *cf, struct Curl_easy *data)
CURL_TRC_CF(data, cf, "destroy");
if(ctx) {
CURL_TRC_CF(data, cf, "cf_osslq_destroy()");
+ cf_osslq_ctx_close(ctx);
cf_osslq_ctx_free(ctx);
}
cf->ctx = NULL;I expected the following
No memory leak.
curl/libcurl version
GIT master as of today, Aug 28, 2024.
operating system
Windows 11 and OpenSSL 3.3.1.
Activity
[-]Memory leak when downgrading from HTTP/3[/-][+]OpenSSL-QUIC: memory leak when downgrading from HTTP/3[/+]openssl quic, fix memory leak
icing commentedon Aug 29, 2024
Thanks for the nice report and the fix. I have applied it in #14724.
ralfjunker commentedon Aug 29, 2024
Thanks for the fast feedback!
Unfortunately, I just noticed that my initial fix caused an AV with a HTTP/3 connection. This one fixes the downgrade leak without the AV. Maybe it is a better option?
icing commentedon Aug 29, 2024
I added to the PR that the close only happens when the SSL* has been initialized. I think it is safer that "destroy" of the filter always cleans up, so callers should not worry.
ralfjunker commentedon Aug 29, 2024
For the record: Your additional cleanup conditional in a2baa2b also fixes the AV.
openssl quic: fix memory leak