Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAVE_POLL_FINE is always false when cross-compiling for Android #15013

Closed
vvb2060 opened this issue Sep 23, 2024 · 7 comments
Closed

HAVE_POLL_FINE is always false when cross-compiling for Android #15013

vvb2060 opened this issue Sep 23, 2024 · 7 comments
Labels
build needs-info

Comments

@vvb2060
Copy link
Contributor

vvb2060 commented Sep 23, 2024

I did this

./configure

I expected the following

#define HAVE_POLL_FINE 1

curl/libcurl version

curl 8.10.1

operating system

Android
@vvb2060
Copy link
Contributor Author

vvb2060 commented Sep 23, 2024

#14734

@dfandrich
Copy link
Contributor

dfandrich commented Sep 23, 2024 via email

@vvb2060
Copy link
Contributor Author

vvb2060 commented Sep 23, 2024 •
edited
Loading

@vszakats _POSIX_C_SOURCE has been deleted in https://r.android.com/237770/6/libc/include/sys/cdefs.h#219 : With bionic, you always get all C and POSIX API.

@vszakats
Copy link
Member

vszakats commented Sep 23, 2024 •
edited
Loading

At compile-time, how do we detect Bionic and this version of Bionic where fine poll is unconditionally available?

@vszakats vszakats added the build label Sep 23, 2024
@vvb2060
Copy link
Contributor Author

vvb2060 commented Sep 23, 2024 •
edited
Loading

https://android.googlesource.com/platform/bionic/+/main/docs/defines.md
I think only Apple's poll is broken? No need to test on other platforms

@vszakats
Copy link
Member

vszakats commented Sep 23, 2024 •
edited
Loading

Are you sure that enabling this unconditionally for all platforms (except Apple) is the correct way to go? There are a lot of platforms out there.

bagder added a commit that referenced this issue Sep 25, 2024
@bagder
build: fix cross-compile check for poll with bionic
8cfb09f 
Since it seems the _POSIX_C_SOURCE "trick" does not work there, the
check does not find poll().

Fixes #15013
Reported-by: vvb2060 on github
@bagder bagder mentioned this issue Sep 25, 2024
Closed
@bagder
Copy link
Member

bagder commented Sep 25, 2024

I propose #15037

@bagder bagder closed this as completed in 7060b9b Sep 25, 2024
@dfandrich dfandrich mentioned this issue Sep 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build needs-info
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix cross-compile check for poll with bionic curl/curl
4 participants
@bagder @dfandrich @vszakats @vvb2060