Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker cached image for dmaketgz may result in wrong release date set #15689

Closed
andrewkirillov-ibm opened this issue Dec 5, 2024 · 1 comment

Comments

@andrewkirillov-ibm
Copy link
Contributor

I did this

Few weeks ago (Nov 13th) I created release packages using ./scripts/dmaketgz <version> as mentioned in RELEASE-PROCEDURE.md

I then created new packages today following same procedure. While the script (docker container) was running it reported:

datestamp 2024-11-13

Checking curlver.h from the new packages shows the same old date - Nov 13th.

As it turns out, the previous time dmaketgz was running, the created docker image was cached and the release date was kept in it as SOURCE_DATE_EPOCH variable. When running it again, docker found a cached image and used it instead of recreating. As a result, I got a new set of packages and release version, but old release date.

I expected the following

Correct date of release in curlver.h

curl/libcurl version

8.11.0

operating system

Red Hat Linux

@andrewkirillov-ibm
Copy link
Contributor Author

andrewkirillov-ibm commented Dec 5, 2024

There are few solutions possible:

  • Mention in release instructions that a docker rmi <image id> should be used remove old cached image.
  • Use --no-cache option when running docker build (which might be safer to avoid user factor errors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant