Compilation for ESP32 on XTENSA architecture

[nkolban]

In the current build environment for libcurl, we find the file called:

curl/include/curl/system.h

contains environmental definitions. In my environment, I wish to build on the ESP32 MCU which uses the XTENSA chip set/architecture. GCC on this environment supplies the pre-defined macro called __XTENSA__. This issue requests a change of the source in system.h from this:

#elif defined(__GNUC__)
#  if !defined(__LP64__) && (defined(__ILP32__) || \
      defined(__i386__) || defined(__ppc__) || defined(__arm__) || \
      defined(__sparc__) || defined(__mips__) || defined(__sh__))

and change to:

#elif defined(__GNUC__)
#  if !defined(__LP64__) && (defined(__ILP32__) || \
      defined(__i386__) || defined(__ppc__) || defined(__arm__) || \
      defined(__sparc__) || defined(__mips__) || defined(__sh__) || defined(__XTENSA__))

[jay]

does it build ok with that change, are the type sizes in that section correct for your platform?

[bagder]

fixed in ceff21a

[jay]

I'd still like to know if this was actually tested on that platform. That section assumes sizeof long is 4 which may not be right

[nkolban]

I had a number of ESP32 users test the suggested change and so far so good. See:

nkolban/esp32-snippets#18

[jay]

ok. on your platform is sizeof(long) 4 or 8

[nkolban]

On the ESP32 device, sizeof(long) evaluates to 4 bytes.

[jay]

ok. thanks for clearing that up