Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error in master with -DENABLE_ARES=ON -DUSE_HTTPSRR=ON -DENABLE_THREADED_RESOLVER=ON #16399

Closed
vszakats opened this issue Feb 19, 2025 · 4 comments
Assignees
Labels

Comments

@vszakats
Copy link
Member

vszakats commented Feb 19, 2025

I did this

Run a curl-for-win build with curl master with -DENABLE_ARES=ON -DUSE_HTTPSRR=ON -DENABLE_THREADED_RESOLVER=ON:

lib/httpsrr.c:210:7: error: use of undeclared identifier 'res'
  210 |       res->hinfo.target = strdup(target);
      |       ^
lib/httpsrr.c:211:11: error: use of undeclared identifier 'res'
  211 |       if(!res->hinfo.target) {
      |           ^
lib/httpsrr.c:215:49: error: use of undeclared identifier 'res'
  215 |       CURL_TRC_DNS(data, "HTTPS RR target: %s", res->hinfo.target);
      |                                                 ^
lib/httpsrr.c:227:3: error: use of undeclared identifier 'res'
  227 |   res->result = result;
      |   ^
4 errors generated.

https://github.com/curl/curl-for-win/actions/runs/13419699486/job/37489127357#step:3:7181

I expected the following

Clean build.

curl/libcurl version

ee3f657

operating system

Linux, macOS, Windows (likely any)

@vszakats vszakats added build name lookup DNS and related tech labels Feb 19, 2025
@vszakats vszakats changed the title build error in master with -DENABLE_ARES=ON -DUSE_HTTPSRR=ON build error in master with -DENABLE_ARES=ON -DUSE_HTTPSRR=ON -DENABLE_THREADED_RESOLVER=ON Feb 19, 2025
@bagder
Copy link
Member

bagder commented Feb 19, 2025

Looks like there is a CI job we should add... 😀

@vszakats
Copy link
Member Author

Yes, or perhaps an existing job can be extended with this.

@bagder bagder self-assigned this Feb 20, 2025
@bagder
Copy link
Member

bagder commented Feb 20, 2025

Extended job in #16402

bagder added a commit that referenced this issue Feb 20, 2025
@bagder bagder closed this as completed in c64304e Feb 20, 2025
bagder added a commit that referenced this issue Feb 20, 2025
It already had ECH enabled. Uses a custom c-ares build since it needs
1.28.0+, not provided in Ubuntu 24.

Ref: #16399
@vszakats
Copy link
Member Author

Thanks @bagder, master builds cleanly now: https://github.com/curl/curl-for-win/actions/runs/13420160744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants