Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed connection not reported as error in cleartext HTTP2 upgrade #166

Closed
bdarnell opened this issue Mar 14, 2015 · 2 comments
Closed

Closed connection not reported as error in cleartext HTTP2 upgrade #166

bdarnell opened this issue Mar 14, 2015 · 2 comments
Assignees
@bagder
Labels
HTTP

Comments

@bdarnell
Copy link

I'm using the multi interface to fetch an HTTP url with CURLOPT_HTTP_VERSION set to CURL_HTTP_VERSION_2 (so HTTP2 is not actually in use; it's an HTTP1 request with an upgrade header). If the server closes the socket without sending a response, this is not reported as an error (curl_multi_info_read returns a result of CURLE_OK). Without setting CURLOPT_HTTP_VERSION it correctly reports CURLE_PARTIAL_FILE.

Versions: libcurl 7.41.0 and nghttp2 0.7.5 on OSX
@bagder bagder self-assigned this Mar 14, 2015
@bagder bagder added the HTTP label Mar 14, 2015
@bagder
Copy link
Member

bagder commented Mar 14, 2015

Thanks, I can repeat it too...

bagder added a commit that referenced this issue Mar 14, 2015
@bagder
http2: detect prematures close without data transfered
0cf649d 
... by using the regular Curl_http_done() method which checks for
that. This makes test 1801 fail consistently with error 56 (which seems
fine) to that test is also updated here.

Reported-by: Ben Darnell
Bug: #166
@bagder
Copy link
Member

bagder commented Mar 14, 2015

Fixed now in commit 0cf649d. Thanks a lot, case closed!

@bagder bagder closed this as completed Mar 14, 2015
@bdarnell bdarnell mentioned this issue Mar 30, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
HTTP
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdarnell @bagder