Skip to content

curl 8.13.0 fails to build with --with-gssapi and --disable-ftp #16925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
x1sc0 opened this issue Apr 2, 2025 · 2 comments
Closed

curl 8.13.0 fails to build with --with-gssapi and --disable-ftp #16925

x1sc0 opened this issue Apr 2, 2025 · 2 comments
Assignees
@bagder
Labels
build regression

Comments

@x1sc0
Copy link

x1sc0 commented Apr 2, 2025

I did this

Hello,
LibreOffice uses curl as an external library.
Today, I tried to upgrade to curl 8.13.0 in https://gerrit.libreoffice.org/c/core/+/183614 but it fails with
/opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/instdir/program/libcurl.so.4: undefined reference to Curl_sec_conn_destroy' [build LNK] Library/libcmdmaillo.so /opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/instdir/program/libcurl.so.4: undefined reference to Curl_sec_conn_init'

See https://ci.libreoffice.org/job/gerrit_linux_gcc_release/185950/consoleFull.
However, if I use --without-gssapi it works

I expected the following

build works

curl/libcurl version

curl 8.13.0

operating system

any distro I believe
@x1sc0 x1sc0 changed the title curl 8.13.0 fails to build with --with-gssapi curl 8.13.0 fails to build with --with-gssapi and --disable-ftp Apr 2, 2025
@x1sc0
Copy link
Author

x1sc0 commented Apr 2, 2025

looking at lib/krb5.c:39 condition

#if defined(HAVE_GSSAPI) && !defined(CURL_DISABLE_FTP)

I do confirm both --with-gssapi and --disable-ftp are needed to trigger the failure, without --disable-ftp it doesn't fail

@vszakats vszakats added the build label Apr 2, 2025
@bagder bagder self-assigned this Apr 2, 2025
bagder added a commit that referenced this issue Apr 3, 2025
@bagder
curl_krbt: only use functions if FTP is still enabled
24d333f 
Reported-by: x1sc0 on github
Fixes #16925
@bagder bagder mentioned this issue Apr 3, 2025
Closed
@bagder bagder closed this as completed in 5caba3b Apr 3, 2025
tdf-gerrit pushed a commit to LibreOffice/core that referenced this issue Apr 3, 2025
curl: upgrade to 8.13.0
5c79209 
* Add external/curl/undefined.patch.0 to handle
curl/curl#16925

Downloaded from https://curl.se/download/curl-8.13.0.tar.xz

Change-Id: I5555cdee13f7660b52ac4a513969dfde1563bf56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183614
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
@x1sc0
Copy link
Author

x1sc0 commented Apr 3, 2025

thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl_krb5: only use functions if FTP is still enabled curl/curl
3 participants
@x1sc0 @bagder @vszakats