cmake: Enabling CURL_COMPLETION_FISH or _ZSH causes build to fail on 8.13.0

[diizzyy]

CMake Error at scripts/CMakeLists.txt:72 (install):
  install FILES given directory "/usr/ports/ftp/curl/work/.build/scripts/" to
  install.

-- Configuring incomplete, errors occurred!
*** Error code 1

curl/libcurl version

curl 8.13.0

operating system

FreeBSD 14.2-RELEASE (amd64)

@vszakats

[vszakats]

Thanks for trying it out.

Readily, I admit not much clue here. The error message doesn't help.

Can you perhaps print out the values of CURL_COMPLETION_FISH_DIR and CURL_COMPLETION_ZSH_DIR before the install() calls via:

message(STATUS "|${CURL_COMPLETION_FISH_DIR}|")
message(STATUS "|${CURL_COMPLETION_ZSH_DIR}|")

or call curl_dumpvars() (strip the output from private things in there if any before pasting here).

[diizzyy]

-- |share/fish/vendor_completions.d|
-- |share/zsh/site-functions|

[diizzyy]

Hmm....

I wonder if it's the Perl script that's causing issues

/usr/ports/ftp/curl/work/curl-8.13.0/scripts # ./completion.pl --opts_dir /usr/ports/ftp/curl/work/curl-8.13.0/docs/cmdline-opts --shell zsh > foo.txt
Unknown option: opts_dir
Usage:
    completion.pl [options...]

        --opts_dir path to cmdline-opts directory
        --shell    zsh/fish
        --help     prints this help

[vszakats]

-- |share/fish/vendor_completions.d|
-- |share/zsh/site-functions|

Thanks. These look fine. (I don't have these installed, so could only do artificial tests around here.)

[dfandrich]

/usr/ports/ftp/curl/work/curl-8.13.0/scripts # ./completion.pl --opts_dir /usr/ports/ftp/curl/work/curl-8.13.0/docs/cmdline-opts --shell zsh > foo.txt Unknown option: opts_dir Usage: completion.pl [options...] --opts_dir path to cmdline-opts directory

Looks like the help documentation is wrong; the option is actually named --opts-dir.

[vszakats]

Hmm....

I wonder if it's the Perl script that's causing issues

/usr/ports/ftp/curl/work/curl-8.13.0/scripts # ./completion.pl --opts_dir /usr/ports/ftp/curl/work/curl-8.13.0/docs/cmdline-opts --shell zsh > foo.txt
Unknown option: opts_dir
Usage:
    completion.pl [options...]

        --opts_dir path to cmdline-opts directory
        --shell    zsh/fish
        --help     prints this help

Interesting! The script calls for --opts-dir. How could it become --opts_dir?

But, the completion.pl help screen is wrong, should say --opts-dir. (fixing)

Also the initial error was in the install() line.

[vszakats]

Mostly just a shot in the dark ...does this improve things for you?: #16954

[diizzyy]

Yes, that fixes the issue! Thanks!

[vszakats]

Nice, thank you too!

[diizzyy]

@vszakats

Hi,

I apologize on my behalf as I seemingly was very tired testing it.
Enabling both ZSH and FISH works, enabling only one causes issues.

Having another look at the scripts/CMakeLists.txt it seems like it doesn't evaluate whether either option is enabled when defining the install section? This seems to work on my end.

https://github.com/curl/curl/blob/master/scripts/CMakeLists.txt#L55
if(CURL_COMPLETION_FISH AND NOT CURL_COMPLETION_FISH_DIR)

https://github.com/curl/curl/blob/master/scripts/CMakeLists.txt#L65
if(CURL_COMPLETION_ZSH AND NOT CURL_COMPLETION_ZSH_DIR)

..and another unrelated note,

include(GNUInstallDirs) in already accessed before scripts dir so there's no need to load it again?
https://github.com/curl/curl/blob/master/CMakeLists.txt#L2059
https://github.com/curl/curl/blob/master/CMakeLists.txt#L2080

Best regards,
Daniel

[vszakats]

No worries, thanks for your reports. Does it look better with?: #17094

[diizzyy]

Yes, tested with all possible combinations. Thanks!

[vszakats]

Thank you, and merged!