clang warning-as-error when building without SSL

[MarcelRaad]

I did this

Build with --without-ssl --enable-werror / -DCURL_ENABLE_SSL=OFF -DCURL_WERROR=ON

I expected the following

A successful build. Instead, I got this:

lib/multi.c:273:5: error: code will never be executed [-Werror,-Wunreachable-code]
273 |     goto error;
    |     ^~~~~~~~~~

See:
https://github.com/curl/curl/blob/rc-8_15_0-1/lib/multi.c#L273
https://github.com/curl/curl/blob/rc-8_15_0-1/lib/vtls/vtls_scache.h#L212

curl/libcurl version

curl 8.15.0-rc1

operating system

macOS with clang

[dfandrich]

"broken" is a bit harsh, given that a break is basically what you're asking for with --enable-werror. I'm not seeing this error on (slightly) older versions of gcc and clang but I can see how it might happen in this case, because Curl_ssl_scache_create() turns into a constant when SSL is disabled.

  if(Curl_ssl_scache_create(sesssize, 2, &multi->ssl_scache))
    goto error;

I'm not sure what the cleanest solution is, though. Disabling the whole call in an #ifdef block is ugly and is what the macro is already accomplishing. Disabling the compiler warning might hide legitimate issues in the code elsewhere. Is there a #pragma or attribute that could be added to the macro to silence this?

[MarcelRaad]

"broken" is a bit harsh, given that a break is basically what you're asking for with --enable-werror

Right, I fixed the issue title, thanks!

[vszakats]

Somehow, unity mode also makes the warning go away, that's why CI did not catch it.