Skip to content

CURLOPT_DNS_CACHE_TIMEOUT -1 argument process regression #18959

Description

@ajax16384

b059f7d introduces new way of processing CURLOPT_DNS_CACHE_TIMEOUT option with function "setopt_set_timeout_sec" .

According to document

disable caching, or set to -1 to make the cached entries remain forever. By

where is special -1 value (remain cache entries forever) for this option and new implentation will disallow to set it with CURLE_BAD_FUNCTION_ARGUMENT result.

  if(secs < 0)
    return CURLE_BAD_FUNCTION_ARGUMENT;

I think it might be serious regression, @bagder please fix this issue.

curl/libcurl version

curl 8.16+

operating system

windows

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions