libCurl build fails with CURL_DISABLE_CRYPTO_AUTH and USE_SSL (causes vtls.c to fail to compile) #1945

Closed
wyattoday opened this Issue Oct 4, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@wyattoday
Contributor

wyattoday commented Oct 4, 2017

I did this

Defined both CURL_DISABLE_CRYPTO_AUTH and USE_SSL.

I expected the following

A successful compilation. Instead I get the following errors:

1>vtls\vtls.c(1065): error C2065: 'MD5_context' : undeclared identifier
1>vtls\vtls.c(1065): error C2065: 'MD5pw' : undeclared identifier
1>vtls\vtls.c(1069): error C2065: 'MD5pw' : undeclared identifier
1>vtls\vtls.c(1069): error C2065: 'Curl_DIGEST_MD5' : undeclared identifier
1>vtls\vtls.c(1070): error C2065: 'MD5pw' : undeclared identifier
1>vtls\vtls.c(1072): error C2065: 'MD5pw' : undeclared identifier
1>vtls\vtls.c(1073): error C2065: 'MD5pw' : undeclared identifier

curl/libcurl version

7.56.0

operating system

Windows, Visual Studio 2017.

A solution (but maybe not the best solution)

In vtls.c add #ifndef CURL_DISABLE_CRYPTO_AUTH around the Curl_none_md5sum function. Then set Curl_ssl_multi md5sum parameter to NULL (instead of Curl_none_md5sum). Do the same for Curl_ssl_schannel md5sum parameter.

@toonetown

This comment has been minimized.

Show comment
Hide comment
@toonetown

toonetown Oct 4, 2017

I am also seeing this when compiling for android, iOS, or macOS.

I am also seeing this when compiling for android, iOS, or macOS.

@bagder bagder added the build label Oct 4, 2017

bagder added a commit that referenced this issue Oct 4, 2017

build: fix --disable-crypto-auth
Reported-by: Wyatt O'Day
Fixes #1945
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 5, 2017

Member

Let me know if (any of) you have any feedback or comments on my proposed fix. If not, I'll merge it soonish.

Member

bagder commented Oct 5, 2017

Let me know if (any of) you have any feedback or comments on my proposed fix. If not, I'll merge it soonish.

@wyattoday

This comment has been minimized.

Show comment
Hide comment
@wyattoday

wyattoday Oct 5, 2017

Contributor

Everything works now with that commit, thanks.

Contributor

wyattoday commented Oct 5, 2017

Everything works now with that commit, thanks.

@wyattoday wyattoday closed this Oct 5, 2017

bagder added a commit that referenced this issue Oct 5, 2017

build: fix --disable-crypto-auth
Reported-by: Wyatt O'Day
Fixes #1945
Closes #1947
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 5, 2017

Member

Thanks!

Member

bagder commented Oct 5, 2017

Thanks!

toonetown added a commit to toonetown/curl that referenced this issue Oct 5, 2017

build: fix --disable-crypto-auth
Reported-by: Wyatt O'Day
Fixes #1945
Closes #1947

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.