Test suite compile failure on Curl_uint32_tbl_clear

[dfandrich]

I did this

Building curl from git commit 1c8c34c (and for at least a few days before that) results in these compile warning and failures:

In file included from /curl-git/tests/unit/unit1300.c:27,
                 from units.c:5:
/curl-git/lib/unitprotos.h:32:45: warning: 'struct uint_spbset' declared inside parameter list will not be visible outside of this definition or declaration
   32 | UNITTEST void Curl_uint_spbset_clear(struct uint_spbset *bset);
      |                                             ^~~~~~~~~~~
/curl-git/lib/unitprotos.h:33:42: warning: 'struct uint_tbl' declared inside parameter list will not be visible outside of this definition or declaration
   33 | UNITTEST void Curl_uint_tbl_clear(struct uint_tbl *tbl);
      |                                          ^~~~~~~~
In file included from units.c:59:
/curl-git/tests/unit/unit3212.c: In function 'test_unit3212':
/curl-git/tests/unit/unit3212.c:109:3: error: implicit declaration of function 'Curl_uint32_tbl_clear'; did you mean 'Curl_uint_tbl_clear'? [-Werror=implicit-function-declaration]
  109 |   Curl_uint32_tbl_clear(&tbl);
      |   ^~~~~~~~~~~~~~~~~~~~~
      |   Curl_uint_tbl_clear
/curl-git/tests/unit/unit3212.c:109:3: warning: nested extern declaration of 'Curl_uint32_tbl_clear' [-Wnested-externs]
In file included from units.c:60:
/curl-git/tests/unit/unit3213.c: In function 'check_spbset':
/curl-git/tests/unit/unit3213.c:41:3: error: implicit declaration of function 'Curl_uint32_spbset_clear'; did you mean 'Curl_uint32_bset_clear'? [-Werror=implicit-function-declaration]
   41 |   Curl_uint32_spbset_clear(&bset);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
      |   Curl_uint32_bset_clear
/curl-git/tests/unit/unit3213.c:41:3: warning: nested extern declaration of 'Curl_uint32_spbset_clear' [-Wnested-externs]
cc1: some warnings being treated as errors
gmake[2]: *** [Makefile:525: units.o] Error 1

The complete build log and configure options will be available shortly at https://curl.se/dev/builds.html with the title Linux (Mageia 9) x86_64 OpenSSL.

I expected the following

Error-free build

curl/libcurl version

8.18.0-DEV

operating system

Mageia 9

[vszakats]

Wondering what may be different in that build to trigger it,
but none in GHA. It's gcc 12 with --with-ssl --enable-tls-srp --enable-warnings:
https://curl.se/dev/log.cgi?id=20251214075856-476106

[bagder]

Seems like the lib/unitprotos.h header file wasn't generated properly?

[dfandrich]

I think you're on to something. I'm doing an out-of-tree build but unitprotos.h was created in the srcdir, not the builddir. It also has an mtime of over a month ago, so something is getting confused.

[dfandrich]

Here's what seems to be happening. When the 'make unitprotos.h' command is run from $(top_builddir)lib/Makefile, the rule does a cd $top_srcdir before running the perl script, which confuses automake. It ends up creating unitprotos.h in srcdir by mistake since it doesn't expect the cd command in there. This is likely to affect anyone running out-of-tree builds who doesn't manually clean up by running rm lib/unitprotos.h in the git tree.