New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative Content-Length: work-around #2212

Closed
bagder opened this Issue Jan 3, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@bagder
Member

bagder commented Jan 3, 2018

Once upon the time we added a work-around to deal with negative Content-Length: values. Back in the days when some Apache installations would have problems with large file sizes larger than 4GB. This work-around is still in place in http.c but Brad figured out it doesn't work anymore because the number parser ignores minuses and instead returns "invalid".

We should remove the leftovers of the work-around and add a test case that verifies that curl behaves correctly for negative content-length values.

There's a larger discussion in the linked mailing list post on how to handle out of range content-lengths, but we have not yet decided on how to deal with those.

Bug: https://curl.haxx.se/mail/lib-2017-12/0061.html
Reported-By: Brad Spencer

@bagder bagder added the HTTP label Jan 3, 2018

bagder added a commit that referenced this issue Jan 9, 2018

HTTP: bail out on negative Content-Length: values
... and make the max filesize check trigger if the value is too big.

Updates test 178.

Fixes #2212

@bagder bagder closed this in f68e672 Jan 13, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.