I did this
The req->connmon = FALSE added in 510fdad prevents the connection monitor from logging more than one disconnect per test. This means test 338 cannot detect if connection reuse fails (two connections opened instead of one), since only the first disconnect is ever recorded.
With the credentials refactoring in 8f71d0f resolving the connection reuse issue that originally required this workaround, the suppression can be removed to restore the test's effectiveness.
A single-line removal in tests/server/sws.c is sufficient — test 338 continues to pass on current master since connection reuse now works correctly.
I expected the following
connection-monitor should log all disconnect events for the lifetime of a test so that tests can detect connection reuse failures.
curl/libcurl version
curl 8.21.0 (master)
operating system
Linux (any)
I did this
The
req->connmon = FALSEadded in 510fdad prevents the connection monitor from logging more than one disconnect per test. This means test 338 cannot detect if connection reuse fails (two connections opened instead of one), since only the first disconnect is ever recorded.With the credentials refactoring in 8f71d0f resolving the connection reuse issue that originally required this workaround, the suppression can be removed to restore the test's effectiveness.
A single-line removal in
tests/server/sws.cis sufficient — test 338 continues to pass on current master since connection reuse now works correctly.I expected the following
connection-monitor should log all disconnect events for the lifetime of a test so that tests can detect connection reuse failures.
curl/libcurl version
curl 8.21.0 (master)
operating system
Linux (any)