New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails; "Curl_setopt()" still referenced in OS400 ccsidcurl.c #2230

Closed
jonrumsey opened this Issue Jan 10, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jonrumsey

jonrumsey commented Jan 10, 2018

I did this

Compile Curl 7.57.0 on OS400

I expected the following

Clean build, however linking LIBCURL *SRVPGM fails as Curl_setopt is still prototyped in lib/url.h and called in packages/OS400/ccsidcurl.c, looks like it was removed from url.c in #1944.

result = Curl_setopt(data, tag, arg);

I think the fix is to make a call to curl_setstropt() instead and to tidy up and remove the old function prototype for Curl_setopt() from url.h.

result = Curl_setstropt(tag, arg);

curl/libcurl version

[curl -V output]
7.57.0

operating system

OS400

@monnerat

This comment has been minimized.

Collaborator

monnerat commented Jan 10, 2018

Well... I have no OS400 access for 18 months but I will try to make it OK again!

Many thanks for reporting, however your hint is not OK: Curl_setstropt() only knows to set string options given a string index. This is not what we want to do.

I have prepared a git branch with a proposed fix: https://github.com/monnerat/curl/tree/setopt400. Please clone/download it and build on OS400, then report results here. If OK, I'll push it in the master.

@jonrumsey

This comment has been minimized.

jonrumsey commented Jan 11, 2018

Thanks for the quick response, your proposed fixes solve the problem.

@jonrumsey jonrumsey closed this Jan 11, 2018

monnerat added a commit that referenced this issue Jan 13, 2018

setopt: reintroduce non-static Curl_vsetopt() for OS400 support
This also upgrades ILE/RPG bindings with latest setopt options.

Reported-By: jonrumsey on github
Fixes #2230
Closes #2233
@monnerat

This comment has been minimized.

Collaborator

monnerat commented Jan 13, 2018

Thanks for your help in testing this fix. Commited in master now: 3b548ff

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.