New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use call rather than batch scripts directly #2330

Closed
rodwiddowson opened this Issue Feb 22, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@rodwiddowson
Contributor

rodwiddowson commented Feb 22, 2018

Over Here @bagder noted (channelling Stefan Kanthak):

Apply the following changes to "winbuild/Makefile.vc" to fix build errors when AppLocker or SAFER alias Software Restriction Policies are in effect

--- curl-7.58.0/winbuild/Makefile.vc    2018-01-22 09:55
+++ curl-patch/winbuild/Makefile.vc
@@ -251,1 +251,1 @@
-    @gen_resp_file.bat $(LIBCURL_OBJS)
+    @CALL gen_resp_file.bat $(LIBCURL_OBJS)
--- curl-7.58.0/winbuild/Makefile.vc    2018-01-22 09:55
+++ curl-patch/winbuild/Makefile.vc
@@ -256,1 +256,1 @@
-    @gen_resp_file.bat $(CURL_OBJS)
+    @CALL gen_resp_file.bat $(CURL_OBJS)

Always use CALL to run batch scripts!

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Feb 22, 2018

Member

Looks good to me. Would you create a PR?

Member

MarcelRaad commented Feb 22, 2018

Looks good to me. Would you create a PR?

@jay jay added the build label Feb 22, 2018

@jay jay closed this in 4fff37b Feb 22, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.