NO_PROXY doesn't work for IPv6 literals. #2353

Closed
steelman opened this Issue Mar 2, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@steelman

steelman commented Mar 2, 2018

I use TOR as a proxy. TOR actually refuses to establish connection to localhost, so I set NO_PROXY

NO_PROXY=localhost,127.0.0.1,::1

It enables connections to http://localhost and http://127.0.0.1 and does not work for http://[::1] at all.
Apparently the problem is caused by an assumption that a hostname cannot contain a colon.

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Mar 3, 2018

Owner

Yes, seems like an accurate observation. Time to add a test case with an IPv6 numerical for this too...

Owner

bagder commented Mar 3, 2018

Yes, seems like an accurate observation. Time to add a test case with an IPv6 numerical for this too...

bagder added a commit that referenced this issue Mar 3, 2018

NO_PROXY: fix for IPv6 numericals in the URL
Reported-by: steelman on github
Fixes #2353
@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Mar 3, 2018

Owner

It'd be great if you can just verify my patch in #2355. I'll try to add a test case for it before I merge anyway.

Owner

bagder commented Mar 3, 2018

It'd be great if you can just verify my patch in #2355. I'll try to add a test case for it before I merge anyway.

@steelman

This comment has been minimized.

Show comment Hide comment
@steelman

steelman Mar 3, 2018

steelman commented Mar 3, 2018

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Mar 3, 2018

Owner

Docs is good indeed. But no, the brackets are not used in the NO_PROXY list. They are however mandatory in the URL itself.

Owner

bagder commented Mar 3, 2018

Docs is good indeed. But no, the brackets are not used in the NO_PROXY list. They are however mandatory in the URL itself.

@steelman

This comment has been minimized.

Show comment Hide comment
@steelman

steelman Mar 3, 2018

Works for me (-: Thanks.

How about updating docs/curl.1 too?

steelman commented Mar 3, 2018

Works for me (-: Thanks.

How about updating docs/curl.1 too?

@bagder bagder closed this in b7f9047 Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment