New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_version_info() documentation is out of date #2364

Closed
lietusme opened this Issue Mar 6, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@lietusme

lietusme commented Mar 6, 2018

I was searching how to identify SSL backend in runtime, got to this page:
https://curl.haxx.se/libcurl/c/curl_version_info.html

ssl_version is an ASCII string for the OpenSSL version used. If libcurl has no SSL support, this is NULL.

In reality ssl_version returns these values when built with different backends:
"WinSSL"
"SecureTransport"
"OpenSSL/1.1.0g"
etc.

Used ibcurl/7.57.0.

Fix would be documentation side I guess, to avoid future confusion. Documenting if this is good way for checking SSL backend would be also useful, I found only this on topic: https://curl.haxx.se/mail/lib-2015-09/0083.html and used empiric methods to get to implementation:

        auto info = curl_version_info(CURLVERSION_NOW);
        if (nullptr != info && nullptr != info->ssl_version && nullptr != strstr(info->ssl_version, "OpenSSL"))

@bagder bagder added the documentation label Mar 6, 2018

@bagder

This comment has been minimized.

Member

bagder commented Mar 13, 2018

Any chance you want to work on fixing this and submitting a PR for it?

@bagder

This comment has been minimized.

Member

bagder commented Mar 17, 2018

Thanks!

@bagder bagder closed this in 9572831 Mar 17, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.