New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests 2056 and 2057 failing on macOS #2394

Closed
jakirkham opened this Issue Mar 16, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@jakirkham

jakirkham commented Mar 16, 2018

When building curl 7.58.0 on macOS 10.10 using Xcode 6.4, seeing tests 2056 and 2057 fail. Details can be found in this build log (linked to failing lines). Can confirm that these failures also occur on macOS 10.11 with Xcode 7.3.1. Also can confirm the issue persists in 7.59.0.

@jakirkham

This comment has been minimized.

jakirkham commented Mar 16, 2018

Unclear as to whether this comment is relevant.

@stale

This comment has been minimized.

stale bot commented Sep 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 12, 2018

@jakirkham

This comment has been minimized.

jakirkham commented Sep 13, 2018

AFAIK this issue remains unresolved.

@stale stale bot removed the stale label Sep 13, 2018

@bagder

This comment has been minimized.

Member

bagder commented Sep 13, 2018

But nobody seems to work on it, why this is silent and the bot marked it as stale. Bugs that don't "move" will get closed eventually and will instead get added to the KNOWN_BUGS document.

@danielgustafsson

This comment has been minimized.

Member

danielgustafsson commented Sep 13, 2018

Is it possible to get error logs and not just the FAILED` lines? I only have access to 10.13 but I can try and reproduce once I know what I'm looking for.

@jakirkham

This comment has been minimized.

jakirkham commented Sep 13, 2018

Ah! Was not aware there was a known bugs doc. Is that in this repo or somewhere else? Also would be great if the bot shared this info when posting as well.

The log is linked in the OP. It selects specific lines, but you are free to move around in the log as well as remove the selection. Please let me know if you have more questions.

@danielgustafsson

This comment has been minimized.

Member

danielgustafsson commented Sep 13, 2018

The buildlog is there yes, but I would like to see the actual logfiles/output from the failing tests.

@bagder

This comment has been minimized.

Member

bagder commented Sep 14, 2018

would be great if the bot shared this info when posting as well.

It is mentioned in the "new issue" template. It was in that text you just skipped over =)

@jakirkham

This comment has been minimized.

jakirkham commented Sep 15, 2018

Hmm...I may have read it 6 months ago and forgot. :) In any event, would still be nice to have the bot mention it. ;)

@jakirkham

This comment has been minimized.

jakirkham commented Sep 15, 2018

@danielgustafsson, not sure I'm following. Can you please tell me how to get the additional information you need? We may need to try a new build to get at it. Happy to update the build to cat whatever files might be useful into the log.

danielgustafsson added a commit to danielgustafsson/curl that referenced this issue Oct 6, 2018

runtests: skip ld_preload tests on macOS
The LD_PRELOAD functionality doesn't exist on macOS, so skip any tests
requiring it.

Closes curl#2394
Closes #xxxx
Reported-by: Github user @jakirkham
@danielgustafsson

This comment has been minimized.

Member

danielgustafsson commented Oct 6, 2018

I took a look at this today, and the reason why the tests are failing on macOS is that they depend on LD_PRELOAD, which doesn't work on macOS. There is actually code in runtests.pl to properly skip the tests in this case, but that codepath has a bug which doesn't exclude macOS from LD_PRELOAD and thus you are seeing this error. A fix proposed in #3106.

A longer term fix is to make this portable such that it uses DYLD_INSERT_LIBRARIES on macOS, but some quick testing shows that it's not as simple as the below diff so I'll add this to the TODO for now.

-LD_PRELOAD=%PWD/libtest/.libs/libstubgss.so
+DYLD_FORCE_FLAT_NAMESPACE=1
+DYLD_INSERT_LIBRARIES=%PWD/libtest/.libs/libstubgss.dylib

danielgustafsson added a commit to danielgustafsson/curl that referenced this issue Oct 6, 2018

TODO: add LD_PRELOAD support on macOS
Add DYLD_INSERT_LIBRARIES support to the TODO list. Reported in curl#2394.

danielgustafsson added a commit that referenced this issue Oct 7, 2018

TODO: add LD_PRELOAD support on macOS
Add DYLD_INSERT_LIBRARIES support to the TODO list. Reported in #2394.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment