Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cookies: use updated public suffix data #2553
I did this
Use curl to work with cookies
I expected the following
Recent PSL updates to have an effect.
curl currently only works with libpsl's built-in PSL database and thus it will slowly go out of date over time unless libpsl is updated with a newer built-in database. Some operating systems (linux distros) now rather provide an "publicsuffix-list" package that updates the PSL data, so if curl would just use the correct libpsl API it could be using more up-to-date PSL information.
This libpsl API: psl_latest, is available since libpsl 0.16.0 (Dec 2016)
Reported-by: Yaakov Selkowitz
We thus need to cache the loaded results somewhere for some amount of time after use to make this bearable and not cause too much of a performance impact. We can't make it globally cached without also making it not thread safe.
Yes. But we can make the multi handle own it so that at least the use case with multiple transfers using the multi api will only use a single copy.
I think we should. I think it should be separate from the existing cookie sharing since the PSL is more likely to be the same for all transfers in an application.