Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
NTLM loops when connection persistence is not available #256
The following 'curl' command is doomed to fail since NTLM requires a persistent connection to complete the negotiation.
I think we could be more graceful, this commit fixes it for me:
I can do a pull request if it is fine.
On Tue, May 5, 2015 at 9:55 PM, Michael Osipov email@example.com
Anyway, the suggested code verifies after fact if the connection is getting
Here is the deal: http://en.wikipedia.org/wiki/HTTP_persistent_connection#HTTP_1.0
On Sun, May 10, 2015 at 4:56 PM, Daniel Stenberg
Anything for a golden star :)
But I think we already have a test case for it, namely:
The reason this test currently passes without the fix is because the
Basically if I change the the 'fake' server response to 'HTTP 1.0' it
Quote from RFC 2145:
So this lead me to test leaving the 'fake' server response as 'HTTP
Currently trying to think of a better alternative for the fix.
referenced this issue
May 19, 2015
The function Curl_http_readwrite_headers() is one big loop and we need to hook after all the headers have been parsed as they can come in any order.
Please review PR #280 I think is OK.