Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
NTLM loops when connection persistence is not available #256
The following 'curl' command is doomed to fail since NTLM requires a persistent connection to complete the negotiation.
I think we could be more graceful, this commit fixes it for me:
I can do a pull request if it is fine.
On Tue, May 5, 2015 at 9:55 PM, Michael Osipov firstname.lastname@example.org
Anyway, the suggested code verifies after fact if the connection is getting
On Sun, May 10, 2015 at 4:56 PM, Daniel Stenberg
Anything for a golden star :)
But I think we already have a test case for it, namely:
The reason this test currently passes without the fix is because the
Basically if I change the the 'fake' server response to 'HTTP 1.0' it
Quote from RFC 2145:
So this lead me to test leaving the 'fake' server response as 'HTTP
Currently trying to think of a better alternative for the fix.
The function Curl_http_readwrite_headers() is one big loop and we need to hook after all the headers have been parsed as they can come in any order.
Please review PR #280 I think is OK.
Curl and libcurl 7.43.0 Public curl releases: 147 Command line options: 176 curl_easy_setopt() options: 219 Public functions in libcurl: 58 Contributors: 1291 This release includes the following changes: o Added CURLOPT_PROXY_SERVICE_NAME o Added CURLOPT_SERVICE_NAME o New curl option: --proxy-service-name o Mew curl option: --service-name  o New curl option: --data-raw  o Added CURLOPT_PIPEWAIT  o Added support for multiplexing transfers using HTTP/2, enable this with the new CURLPIPE_MULTIPLEX bit for CURLMOPT_PIPELINING  o HTTP/2: requires nghttp2 1.0.0 or later o scripts: add zsh.pl for generating zsh completion o curl.h: add CURL_HTTP_VERSION_2 This release includes the following bugfixes: o CVE-2015-3236: lingering HTTP credentials in connection re-use  o CVE-2015-3237: SMB send off unrelated memory contents  o nss: fix compilation failure with old versions of NSS  o curl_easy_getinfo.3: document 'internals' in CURLINFO_TLS_SESSION o schannel.c: Fix possible SEC_E_BUFFER_TOO_SMALL error o Curl_ossl_init: load builtin modules  o configure: follow-up fix for krb5-config  o sasl_sspi: Populate domain from the realm in the challenge  o netrc: support 'default' token o README: convert to UTF-8 o cyassl: Implement public key pinning o nss: implement public key pinning for NSS backend o mingw build: add arch -m32/-m64 to LDFLAGS o schannel: Fix out of bounds array  o configure: remove autogenerated files by autoconf o configure: remove --automake from libtoolize call o acinclude.m4: fix shell test for default CA cert bundle/path o schannel: fix regression in schannel_recv  o openssl: skip trace outputs for ssl_ver == 0  o gnutls: properly retrieve certificate status o netrc: Read in text mode when cygwin  o winbuild: Document the option used to statically link the CRT  o FTP: Make EPSV use the control IP address rather than the original host o FTP: fix dangling conn->ip_addr dereference on verbose EPSV o conncache: keep bundles on host+port bases, not only host names o runtests.pl: use 'h2c' now, no -14 anymore o curlver: introducing new version number (checking) macros o openssl: boringssl build brekage, use SSL_CTX_set_msg_callback  o CURLOPT_POSTFIELDS.3: correct variable names  o curl_easy_unescape.3: update RFC reference  o gnutls: don't fail on non-fatal alerts during handshake o testcurl.pl: allow source to be in an arbitrary directory o CURLOPT_HTTPPROXYTUNNEL.3: only works with a HTTP proxy o SSPI-error: Change SEC_E_ILLEGAL_MESSAGE description  o parse_proxy: switch off tunneling if non-HTTP proxy  o share_init: fix OOM crash o perl: remove subdir, not touched in 9 years o CURLOPT_COOKIELIST.3: Add example o CURLOPT_COOKIE.3: Explain that the cookies won't be modified  o CURLOPT_COOKIELIST.3: Explain Set-Cookie without a domain  o FAQ: How do I port libcurl to my OS? o openssl: Use TLS_client_method for OpenSSL 1.1.0+ o HTTP-NTLM: fail auth on connection close instead of looping  o curl_setup: Add macros for FOPEN_READTEXT, FOPEN_WRITETEXT  o curl_getdate.3: update RFC reference o curl_multi_info_read.3: added example o curl_multi_perform.3: added example o curl_multi_timeout.3: added example o cookie: Stop exporting any-domain cookies  o openssl: remove dummy callback use from SSL_CTX_set_verify() o openssl: remove SSL_get_session()-using code o openssl: removed USERDATA_IN_PWD_CALLBACK kludge o openssl: removed error string #ifdef o openssl: Fix verification of server-sent legacy intermediates  o docs: man page indentation and syntax fixes o docs: Spelling fixes o fopen.c: fix a few compiler warnings o CURLOPT_OPENSOCKETFUNCTION: return error at once  o schannel: Add support for optional client certificates o build: Properly detect OpenSSL 1.0.2 when using configure o urldata: store POST size in state.infilesize too  o security:choose_mech remove dead code o rtsp_do: remove dead code o docs: many HTTP URIs changed to HTTPS o schannel: schannel_recv overhaul  This release includes the following known bugs: o see docs/KNOWN_BUGS (http://curl.haxx.se/docs/knownbugs.html) This release would not have looked like this without help, code, reports and advice from friends like these: Alessandro Ghedini, Alexander Dyagilev, Anders Bakken, Anthony Avina, Ashish Shukla, Bert Huijben, Brian Chrisman, Brian Prodoehl, Chris Araman, Dagobert Michelsen, Dan Fandrich, Daniel Melani, Daniel Stenberg, Dmitry Eremin-Solenikov, Drake Arconis, Egon Eckert, Frank Meier, Fred Stluka, Gisle Vanem, Grant Pannell, Isaac Boukris, Jens Rantil, Joel Depooter, Kamil Dudka, Linus Nielsen Feltzing, Linus Nielsen Feltzing Feltzing, Liviu Chircu, Marc Hoersken, Michael Osipov, Oren Souroujon, Orgad Shaneh, Patrick Monnerat, Patrick Rapin, Paul Howarth, Paul Oliver, Rafayel Mkrtchyan, Ray Satiro, Sean Boudreau, Tatsuhiro Tsujikawa, Tomas Tomecek, Viktor Szakáts, Ville Skyttä, Yehezkel Horowitz, (43 contributors) Thanks! (and sorry if I forgot to mention someone) References to bug reports and discussions on issues:  = http://curl.haxx.se/mail/lib-2015-04/0095.html  = curl/curl#206  = curl/curl@5b66860#commitcomment-10473445  = curl/curl#141  = curl/curl#198  = http://curl.haxx.se/mail/lib-2015-04/0199.html  = curl/curl#244  = curl/curl#219  = curl/curl#258  = curl/curl#254  = http://curl.haxx.se/libcurl/c/CURLOPT_PROXY_SERVICE_NAME.html  = http://curl.haxx.se/libcurl/c/CURLOPT_SERVICE_NAME.html  = http://curl.haxx.se/docs/manpage.html#--proxy-service-name  = http://curl.haxx.se/docs/manpage.html#--service-name  = http://curl.haxx.se/libcurl/c/CURLOPT_PIPEWAIT.html  = http://curl.haxx.se/libcurl/c/CURLMOPT_PIPELINING.html  = curl/curl#275  = curl/curl#281  = curl/curl#282  = curl/curl#267  = http://curl.haxx.se/mail/lib-2015-05/0056.html  = http://curl.haxx.se/mail/lib-2015-05/0115.html  = http://curl.haxx.se/mail/lib-2015-05/0137.html  = curl/curl#256  = curl/curl#258 (comment)  = curl/curl#292  = https://rt.openssl.org/Ticket/Display.html?id=3621&user=guest&pass=guest  = http://curl.haxx.se/mail/lib-2015-06/0047.html  = http://curl.haxx.se/mail/lib-2015-06/0019.html  = http://curl.haxx.se/docs/adv_20150617A.html  = http://curl.haxx.se/docs/adv_20150617B.html  = curl/curl#244