Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB memory leak #2769

Closed
bagder opened this issue Jul 20, 2018 · 0 comments
Closed

SMB memory leak #2769

bagder opened this issue Jul 20, 2018 · 0 comments
Assignees
@bagder
Labels
memory-leak SMB tests

Comments

@bagder
Copy link
Member

bagder commented Jul 20, 2018

I did this

Invoke ./curl_fuzzer_smb [attached file]

I expected the following

It should say nothing bad. Instead it identifies a memory leak.

curl/libcurl version

Current git master. The leaked data sits in the easy-handle and is SMB-specific.

operating system

Any, but Linux is best to reproduce with the fuzzer.

Detected by:

OSS-Fuzz issue 9369 - closed for the public for 30 days starting July 12.

Test file

clusterfuzz-testcase-minimized-curl_fuzzer_smb-5974206117314560
@bagder bagder self-assigned this Jul 27, 2018
bagder added a commit that referenced this issue Jul 29, 2018
@bagder
smb: fix memory leak on early failure
d96aa14 
... by making sure connection related data (->share) is stored in the
connection and not in the easy handle.

Fixes #2769
@bagder bagder mentioned this issue Jul 29, 2018
Closed
bagder added a commit that referenced this issue Jul 30, 2018
@bagder
smb: fix memory leak on early failure
3dd2874 
... by making sure connection related data (->share) is stored in the
connection and not in the easy handle.

Detected by OSS-fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9369
Fixes #2769
Closes #2810
@bagder bagder closed this as completed in 09e401e Jul 30, 2018
xquery pushed a commit to xquery/curl that referenced this issue Aug 9, 2018
@bagder @xquery
smb: fix memory leak on early failure
f848b02 
... by making sure connection related data (->share) is stored in the
connection and not in the easy handle.

Detected by OSS-fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9369
Fixes curl#2769
Closes curl#2810
falconindy pushed a commit to falconindy/curl that referenced this issue Sep 10, 2018
@bagder @falconindy
smb: fix memory leak on early failure
91df7d1 
... by making sure connection related data (->share) is stored in the
connection and not in the easy handle.

Detected by OSS-fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9369
Fixes curl#2769
Closes curl#2810
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2018
@bagder bagder added the SMB label May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
memory-leak SMB tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

smb: fix memory leak on early failure curl/curl
1 participant
@bagder