Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.61 regression: -O -J with http://foo/bar/ URL stopped working #2783

Closed
0-wiz-0 opened this issue Jul 24, 2018 · 1 comment
Closed

7.61 regression: -O -J with http://foo/bar/ URL stopped working #2783

0-wiz-0 opened this issue Jul 24, 2018 · 1 comment
Labels
cmdline tool regression

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jul 24, 2018

I did this

curl -OJ http://some/url/

I expected the following

A file based on the Content-Disposition: attachment; filename="..." to be created.
Instead I got

Warning: Remote filename has no length!
* Failed writing header

curl/libcurl version

Works with:
curl 7.60.0 (x86_64--netbsd) libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.10 libidn2/2.0.4
Release-Date: 2018-05-16
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP UnixSockets HTTPS-proxy

Broken with:
curl 7.61.0 (x86_64--netbsd) libcurl/7.61.0 OpenSSL/1.1.0h zlib/1.2.10 libidn2/2.0.4
Release-Date: 2018-07-11
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP UnixSockets HTTPS-proxy

operating system

NetBSD, but I don't think it matters.
@bagder
Copy link
Member

bagder commented Jul 27, 2018

We should also make sure that we write a test case for this so that we make sure the fix sticks!

bagder added a commit that referenced this issue Jul 30, 2018
@bagder
curl: use Content-Disposition before the "URL end" for -OJ
f5b8bef 
Regression introduced in 7.61.0

Reported-by: Thomas Klausner
Fixes #2783
@bagder bagder mentioned this issue Jul 30, 2018
Closed
@bagder bagder closed this as completed in e78f2cf Jul 31, 2018
xquery pushed a commit to xquery/curl that referenced this issue Aug 9, 2018
@bagder @xquery
curl: use Content-Disposition before the "URL end" for -OJ
dbbd17f 
Regression introduced in 7.61.0

Reported-by: Thomas Klausner
Fixes curl#2783
Closes curl#2813
falconindy pushed a commit to falconindy/curl that referenced this issue Sep 10, 2018
@bagder @falconindy
curl: use Content-Disposition before the "URL end" for -OJ
b9d62bb 
Regression introduced in 7.61.0

Reported-by: Thomas Klausner
Fixes curl#2783
Closes curl#2813
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmdline tool regression
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @0-wiz-0