You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test 1307 fails and shows fice test patterns that error.
Tested with system fnmatch(), linux-style
Curl_fnmatch("[[FF]]", "[FF]") should return FAIL (returns MATCH) [42]
Curl_fnmatch("[![FF]]", "") should return FAIL (returns NOMATCH) [62]
Curl_fnmatch("[![FF]]", "[FF]") should return FAIL (returns NOMATCH) [63]
Curl_fnmatch("[![FF]]", "a") should return FAIL (returns MATCH) [64]
Curl_fnmatch("**]*[*[[13]]**[*[13])]*]*[**[*[13]~r-]*]**[.*]*[[E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3][E3]*[[13]]**[*[13])]*]*[*[[13]]*[~r]*]*[BA][13][A6]~b-]*", "a") should return FAIL (returns NOMATCH) [156]
Interestingly, all the actual returns seem to match what the internal fnmatch function would return.
Presumably, this happens because this is run on an older libc with a different fnmatch implementation that differs from what a modern Linux glibc fnmatch returns for these patterns.
Tests on travis and on my local dev hosts all run this test fine. (glibc 2.27)
This seems complicated to fix for real and I'm leaning towards simply removing those test patterns that differ like this from the test.
I expected the following
All tests to run OK.
curl/libcurl version
current git master but this was introduced in a115c6b when we switched to using the native version when available.
operating system
Linux, but possibly other systems could show similar issues.
The text was updated successfully, but these errors were encountered:
Turns out that since we're using the native fnmatch function now when
available, and they simply disagree on a huge number of test patterns
that make it hard to test this function like this...
Fixescurl#2825
Turns out that since we're using the native fnmatch function now when
available, and they simply disagree on a huge number of test patterns
that make it hard to test this function like this...
Fixescurl#2825
lockbot
locked as resolved and limited conversation to collaborators
Oct 30, 2018
This issue was closed.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I did this
Check autobuilds, like this.
Test 1307 fails and shows fice test patterns that error.
Interestingly, all the actual returns seem to match what the internal fnmatch function would return.
Presumably, this happens because this is run on an older libc with a different fnmatch implementation that differs from what a modern Linux glibc fnmatch returns for these patterns.
Tests on travis and on my local dev hosts all run this test fine. (glibc 2.27)
This seems complicated to fix for real and I'm leaning towards simply removing those test patterns that differ like this from the test.
I expected the following
All tests to run OK.
curl/libcurl version
current git master but this was introduced in a115c6b when we switched to using the native version when available.
operating system
Linux, but possibly other systems could show similar issues.
The text was updated successfully, but these errors were encountered: