Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Make HTTP/0.9 opt-in #2873
Closed
Make HTTP/0.9 opt-in #2873
Assignees
Labels
Comments
|
Ref: #2420 @danielgustafsson are you working on |
|
On 13 Aug 2018, at 20:43, Jay Satiro ***@***.***> wrote:
Ref: #2420
@danielgustafsson are you working on —http0.9
I was, but it fell off my radar due to ETOOMUCHLIFE happening, I’ll try to rebase it on top of the referenced commit this week to finalize it now that the http check went in.
|
|
FYI: I'm grabbing this! |
bagder
added a commit
that referenced
this issue
Dec 17, 2018
|
On 17 Dec 2018, at 15:19, Daniel Stenberg ***@***.***> wrote:
FYI: I'm grabbing this!
Thanks! I’ve had a hard time bubbling this one to the top of my TODO.
|
bagder
added a commit
that referenced
this issue
Dec 19, 2018
bagder
added a commit
that referenced
this issue
Dec 19, 2018
Added CURLOPT_HTTP09_ALLOWED and --http0.9 for this purpose. For now, both the tool and library allow HTTP/0.9 by default. docs/DEPRECATE.md lays out the plan for when to reverse that default: 6 months after the 7.64.0 release. The options are added already now so that applications/scripts can start using them already now. Fixes #2873
bagder
added a commit
that referenced
this issue
Dec 20, 2018
Added CURLOPT_HTTP09_ALLOWED and --http0.9 for this purpose. For now, both the tool and library allow HTTP/0.9 by default. docs/DEPRECATE.md lays out the plan for when to reverse that default: 6 months after the 7.64.0 release. The options are added already now so that applications/scripts can start using them already now. Fixes #2873
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I did this
Use curl to get data from a server that isn't responding with a proper HTTP/1 or HTTP/2 response.
curl will gladly hand over the received data as HTTP body. This is because it supports "HTTP/0.9", which is how HTTP used to work before 1.0 (1996): that's just body bytes that ends with a closed connection.
I expected the following
It should report an error if the response is not HTTP protocol compliant. I suspect this "liberal in what you accept" and treating everything as HTTP/0.9 might be surprising to users and I'm also afraid it could cause some unexpected behaviors.
HTTP/0.9 support should therefor be done opt-in. mentioned on the mailing list in July 2018 - no objections there.
curl/libcurl version
curl 7.61.1 still has it supported by default.
operating system
All
Releated
HTTP/0.9 detection was improved in #2872 after which fixing this issue should be pretty easy.