Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAssume OpenSSL engine support in 0.9.8 or later #2983
Comments
bagder
added
the
SSL/TLS
label
Sep 13, 2018
This comment has been minimized.
This comment has been minimized.
I figure the comment needs an update too! |
added a commit
that referenced
this issue
Sep 13, 2018
bagder
referenced this issue
Sep 13, 2018
Closed
openssl: assume engine support in 0.9.8 or later #2988
This comment has been minimized.
This comment has been minimized.
I turned it into a PR (with you as author). |
bagder
closed this
in
1599dfc
Sep 14, 2018
lock
bot
locked as resolved and limited conversation to collaborators
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
rainerjung commentedSep 12, 2018
Commit d6417f6 added inclusion of engine.h when OpenSSL is of version 1.0.0 or newer. That's good, but the conservative approach t limit the fix to OpenSSL >= 1.0.0 isn't correct. ENGINE_cleanup() and other needed symbols, which get used to HAVE-checks and need engine.h were already introduced at least in 0.9.8. I tried building curl 7.61.1 against OpenSSL 0.9.8 for testing with some old setup and building curl fails.
The following will fix it at least for 0.9.8. I have not tested with 0.9.7, so will rstrict the fix to 0.9.8. Patch: