Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
curl 7.60.0 can list & work with openssl engines while curl 7.61.1 can't #3023
In the following, openssl is openssl @1.0.2p_0. The same openssl.cnf is used for both test
I did this
I expected the following
Mac OS 10.13.6 & MacPorts 2.5.3
Well I tried with 7.61.1 too. No more success :
changed the title from
curl 7.60.0 can list & work with openssl engines while curl 7.61.0 can't
curl 7.60.0 can list & work with openssl engines while curl 7.61.1 can't
Sep 20, 2018
You are right, sorry. Mistake was on my side because I did not run buildconf between each bisect.
So, bisecting properly between 7_60_0 and 7_61_0 confirms that 38203f1 is the first bad commit.
Is this the missing piece?
diff --git a/lib/vtls/openssl.c b/lib/vtls/openssl.c index 230eea2d0..551298926 100644 --- a/lib/vtls/openssl.c +++ b/lib/vtls/openssl.c @@ -976,11 +976,11 @@ static int Curl_ossl_init(void) char *keylog_file_name; #endif OPENSSL_load_builtin_modules(); -#ifdef HAVE_ENGINE_LOAD_BUILTIN_ENGINES +#ifdef USE_OPENSSL_ENGINE ENGINE_load_builtin_engines(); #endif /* OPENSSL_config(NULL); is "strongly recommended" to use but unfortunately that function makes an exit() call on wrongly formatted config files