New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows VT Support and UTF-8 output doesn't restore font #3211

Closed
bagder opened this Issue Nov 1, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@bagder
Member

bagder commented Nov 1, 2018

This is very ugly change. Changing console codepage effect console font. Also you probably notice that curl doesn't restore original font.

shoei

@bitcrazed This is NOT right way to show unicode. You should use wide string APIs.

Originally posted by @mattn in #3008 (comment)

mattn added a commit to mattn/curl that referenced this issue Nov 1, 2018

mattn added a commit to mattn/curl that referenced this issue Nov 1, 2018

@bitcrazed

This comment has been minimized.

Contributor

bitcrazed commented Nov 1, 2018

Thanks for fixing @mattn

@bagder

This comment has been minimized.

Member

bagder commented Nov 1, 2018

So, an innocent question from someone not usually on Windows: how annoying is this bug for a typical user? Would you (the plural you, anyone!) say this is a reason enough to do a patch release or can we live with it for six weeks?

@bitcrazed

This comment has been minimized.

Contributor

bitcrazed commented Nov 1, 2018

My feel for this is that this is fundamentally a cosmetic issue (i.e. I don't think it breaks functionality/behavior, right?), though to what degree is a good question for @mattn.

@mattn

This comment has been minimized.

Contributor

mattn commented Nov 2, 2018

IMO, This doesn't break functionality but curl harms to console. For example, if we use curl in Vim plugin, console is broken. I strongly wish getting this fix immediately.

terminal6

@bagder bagder closed this in 5bfaa86 Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment