GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
This is very ugly change. Changing console codepage effect console font. Also you probably notice that curl doesn't restore original font.
@bitcrazed This is NOT right way to show unicode. You should use wide string APIs.
Originally posted by @mattn in #3008 (comment)
curl: revert curl#3011 and write UTF-8 in current console code page.
curl: write UTF-8 in current console code page.
Thanks for fixing @mattn
So, an innocent question from someone not usually on Windows: how annoying is this bug for a typical user? Would you (the plural you, anyone!) say this is a reason enough to do a patch release or can we live with it for six weeks?
My feel for this is that this is fundamentally a cosmetic issue (i.e. I don't think it breaks functionality/behavior, right?), though to what degree is a good question for @mattn.
IMO, This doesn't break functionality but curl harms to console. For example, if we use curl in Vim plugin, console is broken. I strongly wish getting this fix immediately.