Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows VT Support and UTF-8 output doesn't restore font #3211
Labels
Comments
mattn
added a commit
to mattn/curl
that referenced
this issue
Nov 1, 2018
mattn
added a commit
to mattn/curl
that referenced
this issue
Nov 1, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks for fixing @mattn |
This comment has been minimized.
This comment has been minimized.
|
So, an innocent question from someone not usually on Windows: how annoying is this bug for a typical user? Would you (the plural you, anyone!) say this is a reason enough to do a patch release or can we live with it for six weeks? |
This comment has been minimized.
This comment has been minimized.
|
My feel for this is that this is fundamentally a cosmetic issue (i.e. I don't think it breaks functionality/behavior, right?), though to what degree is a good question for @mattn. |
This comment has been minimized.
This comment has been minimized.
|
IMO, This doesn't break functionality but curl harms to console. For example, if we use curl in Vim plugin, console is broken. I strongly wish getting this fix immediately.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is very ugly change. Changing console codepage effect console font. Also you probably notice that curl doesn't restore original font.
@bitcrazed This is NOT right way to show unicode. You should use wide string APIs.
Originally posted by @mattn in #3008 (comment)