Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upunexpected bad/illegal url format error. A short host + port is treated as a scheme! #3220
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
And curiously a |
This comment has been minimized.
This comment has been minimized.
|
Ack, a regression from 46e1640. PR coming up. |
bagder
added a commit
that referenced
this issue
Nov 2, 2018
The function identifying a leading "scheme" part of the URL considered a few letters ending with a colon to be a scheme, making something like "short:80" to become an unknown scheme instead of a short host name and a port number. Extended test 1560 to verify. Reported-by: Hagai Auro Fixes #3220
bagder
added a commit
that referenced
this issue
Nov 2, 2018
The function identifying a leading "scheme" part of the URL considered a few letters ending with a colon to be a scheme, making something like "short:80" to become an unknown scheme instead of a short host name and a port number. Extended test 1560 to verify. Reported-by: Hagai Auro Fixes #3220
bagder
added a commit
that referenced
this issue
Nov 5, 2018
The function identifying a leading "scheme" part of the URL considered a few letters ending with a colon to be a scheme, making something like "short:80" to become an unknown scheme instead of a short host name and a port number. Extended test 1560 to verify. Also fix test203 to use posix_pwd to make it get the correct path on windows Reported-by: Hagai Auro Fixes #3220 Fixes #3233 Closes #3223 Closes #3235
This comment has been minimized.
This comment has been minimized.
bagder
changed the title
bagder
added a commit
that referenced
this issue
Nov 6, 2018
The function identifying a leading "scheme" part of the URL considered a few letters ending with a colon to be a scheme, making something like "short:80" to become an unknown scheme instead of a short host name and a port number. Extended test 1560 to verify. Also fix test203 to use posix_pwd to make it get the correct path on windows Reported-by: Hagai Auro Fixes #3220 Fixes #3233 Closes #3223 Closes #3235
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The scenario is that I have a hostname
boingin/etc/hostspointing to 127.0.0.1 , and I port-forward to the real host.I did this
$ curl boing:80curl: (3) URL using bad/illegal format or missing URLand if I did:
$ curl http://boing:80it worked
I expected the following
I expected it to actually issue the request, but to illustrate the change from a previous version, if I hadn't defined
boingin/etc/hosts, I'd get this:$ curl boing:80curl: (6) Could not resolve host: boingcurl/libcurl version
$ curl -Vcurl 7.62.0 (x86_64-apple-darwin16.7.0) libcurl/7.62.0 OpenSSL/1.0.2p zlib/1.2.8 libidn2/2.0.5 Release-Date: 2018-10-31 Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp Features: AsynchDNS IDN IPv6 Largefile NTLM NTLM_WB SSL libz TLS-SRP UnixSockets HTTPS-proxyoperating system
$ uname -aDarwin hagai-mba-osx 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 21 20:07:39 PDT 2018; root:xnu-3789.73.14~1/RELEASE_X86_64 x86_64 i386 MacBookAir6,2 Darwin