New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl --local-port does not try last port in range #3251

Closed
infinnovation-dev opened this Issue Nov 8, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@infinnovation-dev

infinnovation-dev commented Nov 8, 2018

(Mentioned in passing in #3248 but now raising as a separate issue.)

I did this

freia013:~/work/curl $ src/curl --local-port 1023-1024 localhost
curl: (45) bind failed with errno 13: Permission denied
freia013:~/work/curl $ src/curl --local-port 1024 localhost
curl: (7) Failed to connect to localhost port 80: Connection refused
freia013:~/work/curl $ src/curl --local-port 1023-1025 localhost
curl: (7) Failed to connect to localhost port 80: Connection refused

I expected the following

With "1023-1024", curl should try to use port 1024 when 1023 fails, but it only tries 1023 then gives up. If I increase the range to "1023-1025" then it does use 1024. This can be seen in greater detail with additional -v or -libcurl.

localportrange needs to be incremented by one when subtracting last from first.

curl/libcurl version

f859b05

@bagder bagder added the cmdline tool label Nov 9, 2018

@bagder

This comment has been minimized.

Member

bagder commented Nov 9, 2018

localportrange needs to be incremented by one when subtracting last from first

Ack, it does!

bagder added a commit that referenced this issue Nov 9, 2018

curl: --local-port range was not "including"
The end port number in a given range was not included in the range used,
as it is documented to be.

Reported-by: infinnovation-dev on github
Fixes #3251

@bagder bagder closed this in fcf3f13 Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment