/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No license for impacket code? #3276

Closed
infinnovation-dev opened this Issue Nov 15, 2018 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@infinnovation-dev @bagder
@infinnovation-dev

infinnovation-dev commented Nov 15, 2018

I did this

Looked for an accompanying LICENSE (modified Apache) as mentioned by the header of tests/python_dependencies/impacket/*.py

I expected the following

To find something relevant, maybe in docs/LICENSE-MIXING.md

N.B. It looks like we have only a subset of the full impacket project.

@infinnovation-dev infinnovation-dev changed the title from No license for impacket code to No license for impacket code? Nov 15, 2018

bagder added a commit that referenced this issue Nov 15, 2018

@bagder
impacket: add LICENSE 
The license for the impacket package was not in our tree.

Imported now from upstream's
https://github.com/SecureAuthCorp/impacket/blob/master/LICENSE

Reported-by: infinnovation-dev on github
Fixes #3276
Verified
This commit was signed with a verified signature.
@bagder bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
dd4d3cb

@bagder bagder referenced this issue Nov 15, 2018

Closed

impacket: add LICENSE #3277

bagder added a commit that referenced this issue Nov 15, 2018

@bagder
impacket: add LICENSE 
The license for the impacket package was not in our tree.

Imported now from upstream's
https://github.com/SecureAuthCorp/impacket/blob/master/LICENSE

Reported-by: infinnovation-dev on github
Fixes #3276
Verified
This commit was signed with a verified signature.
@bagder bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
3a1cd68

@bagder bagder added documentation tests labels Nov 15, 2018

@bagder bagder closed this in a04ed00 Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment