Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No license for impacket code? #3276

Closed
infinnovation-dev opened this issue Nov 15, 2018 · 0 comments
Closed

No license for impacket code? #3276

infinnovation-dev opened this issue Nov 15, 2018 · 0 comments
Labels
documentation tests

Comments

@infinnovation-dev
Copy link

@infinnovation-dev infinnovation-dev commented Nov 15, 2018

I did this

Looked for an accompanying LICENSE (modified Apache) as mentioned by the header of tests/python_dependencies/impacket/*.py

I expected the following

To find something relevant, maybe in docs/LICENSE-MIXING.md

N.B. It looks like we have only a subset of the full impacket project.
@infinnovation-dev infinnovation-dev changed the title No license for impacket code No license for impacket code? Nov 15, 2018
bagder added a commit that referenced this issue Nov 15, 2018
@bagder
impacket: add LICENSE
Verified
This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about vigilant mode.
Loading status checks…
dd4d3cb 
The license for the impacket package was not in our tree.

Imported now from upstream's
https://github.com/SecureAuthCorp/impacket/blob/master/LICENSE

Reported-by: infinnovation-dev on github
Fixes #3276
@bagder bagder mentioned this issue Nov 15, 2018
Closed
bagder added a commit that referenced this issue Nov 15, 2018
@bagder
impacket: add LICENSE
Verified
This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about vigilant mode.
Loading status checks…
3a1cd68 
The license for the impacket package was not in our tree.

Imported now from upstream's
https://github.com/SecureAuthCorp/impacket/blob/master/LICENSE

Reported-by: infinnovation-dev on github
Fixes #3276
@bagder bagder closed this in a04ed00 Nov 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation tests
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bagder @infinnovation-dev