Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: DarwinSSL setting not passed to curl configuration #3733

Closed
webmaster128 opened this issue Apr 5, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@webmaster128
Copy link
Contributor

commented Apr 5, 2019

In #3619, USE_DARWINSSLwas renamed to USE_SECTRANSP. However, in https://github.com/curl/curl/blob/curl-7_64_1/CMakeLists.txt#L344 the old configuration is used.

This currently leads to an active DarwinSSL feature but no SSL backend:

$ bash /build_dir/curl/curl-config --features
DarwinSSL
IPv6
unix-sockets
libz
AsynchDNS
$ bash /build_dir/curl/curl-config --ssl-backends

(btw: where does this empty output line come from?).

I'm working on a PR to get this fixed.

@webmaster128

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

In configure.ac, SUPPORT_FEATURES does not contain the individual SSL backends, but in CMakeLists.txt they are listed individually, which leads to different results in curl-config and libcurl.pc.

I think this should be standardized before adding a new feature name to that list ("Secure Transport" or "SecureTransport"). What do you think?

@bagder bagder added the cmake label Apr 5, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

It's even called secure-transport at times in the configure script. I think if the name can be done with a space then the full official name is the better option, but I opted for the space-less version in the version output just to make it simpler for shell scripts that typically separate strings on spaces.

The specific SSL backend is not a "feature" so it doesn't need to be listed there. It should contain SSL if built with SSL support present, that's the feature.

@webmaster128

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Done by #3769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.