CMake: configure may fail when building with custom GSSAPI build #3743

jzakrzewski · 2019-04-07T10:36:45Z

Configuring build of curl 7.64.1 with example command line like:
cmake ../curl -DCMAKE_INSTALL_PREFIX=/work/curl-install -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_USE_GSSAPI=ON -DGSS_ROOT_DIR=/work/krb5-1.17-install -DCMAKE_USE_OPENSSL=OFF -DCMAKE_PREFIX_PATH:PATH=/work/krb5-1.17-install -DCURL_CA_PATH=none -G Ninja

Fails when checking for recv. Error log reveals that it tries to link the Kerberos libraries, which is totally unnecessary.

PR will follow.


        cmake: clear CMAKE_REQUIRED_LIBRARIES after each use

fixes curl#3743


        cmake: avoid linking executable for some tests with cmake 3.6+

With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. Would also avoid curl#3743 on itself with cmake 3.6 or above.


        cmake: avoid linking executable for some tests with cmake 3.6+

With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. Would also avoid curl#3743 on itself with cmake 3.6 or above. Ref: curl#3744


        cmake: clear CMAKE_REQUIRED_LIBRARIES after each use

fixes curl#3743 closes curl#3744


        cmake: avoid linking executable for some tests with cmake 3.6+

With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. This commit also avoids curl#3743 (GSSAPI build errors) on itself with cmake 3.6 or above. That issue was fixed separately for all versions. Ref: curl#3744


        cmake: clear CMAKE_REQUIRED_LIBRARIES after each use

This fixes GSSAPI builds with the libraries in a non-standard location. The testing for recv() were failing because it failed to link the Kerberos libraries, which are not needed for this or subsequent tests. fixes curl#3743 closes curl#3744


        cmake: avoid linking executable for some tests with cmake 3.6+

With CMAKE_TRY_COMPILE_TARGET_TYPE set to STATIC_LIBRARY, the try_compile() (which is used by check_c_source_compiles()) will build static library instead of executable. This avoids linking additional libraries in and thus speeds up those checks a little. This commit also avoids #3743 (GSSAPI build errors) on itself with cmake 3.6 or above. That issue was fixed separately for all versions. Ref: #3744

jzakrzewski added a commit to jzakrzewski/curl that referenced this issue Apr 7, 2019

cmake: clear CMAKE_REQUIRED_LIBRARIES after each use

7390b64

fixes curl#3743

jzakrzewski mentioned this issue Apr 7, 2019

cmake: Fix build with GSSAPI #3744

Closed

bagder added the cmake label Apr 7, 2019

jzakrzewski added a commit to jzakrzewski/curl that referenced this issue Apr 8, 2019

cmake: clear CMAKE_REQUIRED_LIBRARIES after each use

136f518

fixes curl#3743 closes curl#3744

jzakrzewski closed this in ff1cb97 Apr 10, 2019

lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019

curl / curl

CMake: configure may fail when building with custom GSSAPI build #3743

CMake: configure may fail when building with custom GSSAPI build #3743

jzakrzewski commented Apr 7, 2019

curl / curl

Sponsor curl/curl

Join GitHub today

CMake: configure may fail when building with custom GSSAPI build #3743

CMake: configure may fail when building with custom GSSAPI build #3743

Comments

jzakrzewski commented Apr 7, 2019