Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USE_DARWINSSL still used in packages/vms #3768

Closed
webmaster128 opened this issue Apr 12, 2019 · 2 comments
Closed

USE_DARWINSSL still used in packages/vms #3768

webmaster128 opened this issue Apr 12, 2019 · 2 comments
Labels
build

Comments

@webmaster128
Copy link
Contributor

@webmaster128 webmaster128 commented Apr 12, 2019

The outdated USE_DARWINSSL is still used in some files inside of packages/vms:

$ git grep -C 4 USE_DARWINSSL
packages/vms/generate_config_vms_h_curl.com-$write cvh "#endif"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#ifdef USE_CYASSL"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#undef USE_CYASSL"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#endif"
packages/vms/generate_config_vms_h_curl.com:$write cvh "#ifdef USE_DARWINSSL"
packages/vms/generate_config_vms_h_curl.com:$write cvh "#undef USE_DARWINSSL"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#endif"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#ifdef USE_GNUTLS"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#undef USE_GNUTLS"
packages/vms/generate_config_vms_h_curl.com-$write cvh "#endif"

Since I have no idea what this folder does, I don't want to touch it.
@bagder bagder added the build label Apr 12, 2019
@bagder
Copy link
Member

@bagder bagder commented Apr 12, 2019

I presume that's pretty harmless though since surely you cannot use Secure Transport (or darwinssl) on VMS anyway...

This file seems to be generated by the build_vms.com script...
@bagder
Copy link
Member

@bagder bagder commented Apr 12, 2019

/cc @wb8tyw
captain-caveman2k added a commit to captain-caveman2k/curl that referenced this issue Apr 15, 2019
@captain-caveman2k
openvms: Use the correct pre-processor directive for SecureTransport
08b03e6 
Fixes curl#3768
@captain-caveman2k captain-caveman2k mentioned this issue Apr 15, 2019
Closed
captain-caveman2k added a commit to captain-caveman2k/curl that referenced this issue Apr 15, 2019
@captain-caveman2k
openvms: Use the correct pre-processor directive for SecureTransport
24cf608 
Fixes curl#3768
captain-caveman2k added a commit to captain-caveman2k/curl that referenced this issue Apr 16, 2019
@captain-caveman2k
openvms: Remove pre-processor for SecureTransport as VMS cannot suppo…
7841597 
…rt it

Fixes curl#3768
@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

openvms: Remove pre-processor directives that cannot be used on VMS
2 participants
@bagder @webmaster128