Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify use of CURLOPT_RANGE on upload #3814

Closed
jay opened this issue Apr 30, 2019 · 3 comments
Closed

Clarify use of CURLOPT_RANGE on upload #3814

jay opened this issue Apr 30, 2019 · 3 comments
Labels
documentation libcurl API

Comments

@jay
Copy link
Member

jay commented Apr 30, 2019 •
edited

I did this

Christopher Head (@Hawk777) reported on the mailing list that CURLOPT_RANGE does not work properly for ranged PUTs. I replied saying PUT is only for complete replacement of a resource, not partial. He replied saying Amazon allows ranged PUTs (doc).

I expected the following

The documentation does not specify the behavior of CURLOPT_RANGE on upload, so we should clarify that and in doing so decide whether or not what was reported is a bug (I think it's not since it's against the RFC).
@bagder
Copy link
Member

bagder commented May 3, 2019

curl has an approach to resumed uploads with PUT, even though it isn't encouraged nor specified in the RFC. It has however existed for a long time so we don't want to break it either.

For example, test 1001 and 1041 verify the existing functionality.

@jay
Copy link
Member Author

jay commented May 16, 2019 •
edited

What do you think about changing the doc to link to caution against using CURLOPT_RANGE for PUT uploads?

See my final analysis at https://curl.haxx.se/mail/lib-2019-05/0012.html in the reply quoted and current

@bagder
Copy link
Member

bagder commented May 16, 2019

Absolutely, propose a change if you can come up with wording you think will help users!

@curl curl deleted a comment from Simonair99 Jun 12, 2019
@jay jay closed this as completed in 28f6fda Jul 17, 2019
caraitto pushed a commit to caraitto/curl that referenced this issue Jul 23, 2019
@jay @caraitto
CURLOPT_RANGE.3: Caution against using it for HTTP PUT
4947a30 
AFAICT CURLOPT_RANGE does not support ranged HTTP PUT uploads so I've
cautioned against using it for that purpose and included a workaround.

Bug: https://curl.haxx.se/mail/lib-2019-04/0075.html
Reported-by: Christopher Head

Closes curl#3814
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation libcurl API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @jay