speed time triggers without regard for limit

[falconindy]

I did this

#include <stdio.h>
#include <curl/curl.h>

static int dload_progress_cb(void *a, curl_off_t b, curl_off_t c, curl_off_t d, curl_off_t e) {
  return 0;
}

int main(void) {
  CURLcode ret;
  CURL *hnd;
  FILE* devnull;
  char errorbuffer[CURL_ERROR_SIZE] = {};

  devnull = fopen("/dev/null", "w");

  hnd = curl_easy_init();
  curl_easy_setopt(hnd, CURLOPT_URL, "http://speedtest.wdc01.softlayer.com/downloads/test500.zip");
  curl_easy_setopt(hnd, CURLOPT_LOW_SPEED_LIMIT, 1L);
  curl_easy_setopt(hnd, CURLOPT_LOW_SPEED_TIME, 5L);
  curl_easy_setopt(hnd, CURLOPT_WRITEDATA, devnull);
  curl_easy_setopt(hnd, CURLOPT_ERRORBUFFER, errorbuffer);

  /* problematic options */
  curl_easy_setopt(hnd, CURLOPT_NOPROGRESS, 0L);
  curl_easy_setopt(hnd, CURLOPT_XFERINFOFUNCTION, dload_progress_cb);

  ret = curl_easy_perform(hnd);
  if (ret != CURLE_OK) {
    printf("error: %s\n", errorbuffer);
  }

  curl_easy_cleanup(hnd);

  return (int)ret;
}

The program exits unsuccessfully after logging

error: Operation too slow. Less than 1 bytes/sec transferred the last 5 seconds

I've bisected this to 3b06e68.

I expected the following

Successful exit.

curl/libcurl version

curl 7.65.0 (x86_64-pc-linux-gnu) libcurl/7.65.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.1.1) libssh2/1.8.2 nghttp2/1.36.0
Release-Date: 2019-05-22
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets

operating system

Arch Linux, baseline kernel version 5.1.1

[bagder]

Thanks for the recipe. I suppose the easiest work-around for this issue could be to just revert that particular commit. Did you try that?

[falconindy]

I guess I should have tried that. Yes, reverting the mentioned commit fixes it.

[jackiepluto]

What is the schedule of next official release to fix this issue?

[bagder]

ETA of 7.65.1 is about 20 hours! 😄

[JulesRapanga]

I believe that commit also breaks CURLINFO_TOTAL_TIME (always returns zero in 7.65.0, works in 7.65.1 and previous).
Makes sense as it comes from progress.timespent which is in that area.

[bagder]

Yes it did. But water under the bridge now!