Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi socket: segfault when given a redirect #3952

Closed
TvdW opened this issue May 27, 2019 · 1 comment

Comments

@TvdW
Copy link

commented May 27, 2019

I did this

https://gist.github.com/TvdW/3807e802463c712e2c5909c772a9d863

This code segfaults for me. Could be related to #3904, not sure.

I expected the following

No segfault

curl/libcurl version

curl 7.65.0 (x86_64-pc-linux-gnu) libcurl/7.65.0 OpenSSL/1.0.2k-fips zlib/1.2.7 brotli/1.0.1 c-ares/1.15.0 nghttp2/1.38.0
Release-Date: 2019-05-22
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS brotli HTTP2 HTTPS-proxy IPv6 Largefile libz NTLM NTLM_WB SSL UnixSockets

operating system

CentOS 7, custom-built curl

@bagder bagder self-assigned this May 27, 2019
@bagder bagder added the crash label May 27, 2019
@bagder

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Looks very similar to #3904

bagder added a commit that referenced this issue May 28, 2019
They need to be removed from the socket hash linked list with more care.

When sh_delentry() is called to remove a sockethash entry, remove all
individual transfers from the list first. To enable this, each Curl_easy struct
now stores a pointer to the sockethash entry to know how to remove itself.

Reported-by: Tom van der Woerdt and Kunal Ekawde

Fixes #3952
Fixes #3904
@bagder bagder closed this in 8581e19 May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.